odoo icon indicating copy to clipboard operation
odoo copied to clipboard

[FIX] point_of_sale: not show inactive variant attributes in the shop

Open sbel-odoo opened this issue 1 year ago • 1 comments

Currently, if you select a product that has variants, the popup window to choose the variants shows both active and inactive variants.

Steps to reproduce:

  • Make a quotation with the product Desk Organizer and select Plastic as its variant -> Confirm
  • Go to Products
  • Select Desk Organizer
  • Go to Attributes & Variants
  • Remove the Plastic option

    The variant is now inactive

  • Go to the Point of Sale App
  • Open a shop session
  • Select the Desk Organizer product

Observation: the Plastic variant is shown

Why the fix:

We compare the workflow with sales, when doing a new quotation with the Desk Organizer product, the inactive variant is not an option to select.

We now load the information about attribute values being active or not when loading the data to the POS Session. All attributes that are inactive will not be shown in the product configurator.

opw-3713374

sbel-odoo avatar May 10 '24 13:05 sbel-odoo

Pull request status dashboard.

robodoo avatar May 10 '24 13:05 robodoo

LGTM

robinengels avatar May 21 '24 10:05 robinengels

@sbel-odoo Perhaps in the forward ports you could merge the new test into the existing product configurator tour

vlst-odoo avatar May 21 '24 13:05 vlst-odoo

@sbel-odoo Perhaps in the forward ports you could merge the new test into the existing product configurator tour

No problem, I'll keep that in mind :) Thank you

sbel-odoo avatar May 21 '24 14:05 sbel-odoo

@sbel-odoo @vlst-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

  • odoo/odoo#166666

fw-bot avatar May 25 '24 05:05 fw-bot

@sbel-odoo @vlst-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

  • odoo/odoo#166666

fw-bot avatar May 26 '24 05:05 fw-bot

@sbel-odoo @vlst-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

  • odoo/odoo#166666

fw-bot avatar May 27 '24 05:05 fw-bot

@sbel-odoo @vlst-odoo this pull request has forward-port PRs awaiting action (not merged or closed):

  • odoo/odoo#166956

fw-bot avatar May 28 '24 05:05 fw-bot