odoo [FIX] l10n_cl: fix to allow credit notes code 61 over purchase vendor bills code 46

[FIX] l10n_cl: fix to allow credit notes code 61 over purchase vendor bills code 46

Open Danisan opened this issue 1 year ago • 3 comments

Description of the issue/feature this PR addresses: Before this fix, It was not possible to issue a credit note code 61 to be applied to an invoice of type '46' when the vendor was foreign. Typically, credit notes for foreign vendors are code 112; however, code 61 is necessary to reverse a type 46 invoice.

After this PR: In the validation included in this PR, we allow this credit note type 61, provided there is a reference to a code '46' invoice, included in the document reference model.

This PR corresponds to the odoo/enterprise PR enabling the issuance of type 46 invoices referenced below:

https://github.com/odoo/enterprise/pull/59876

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

May 09 '24 19:05 Danisan

May 09 '24 19:05 robodoo

@lordkrandel This is about https://github.com/odoo/enterprise/pull/59876 reviews.

May 09 '24 19:05 Danisan

Small change.

@fvz-odoo I've requested some minor cosmetic/implementation changes to @Danisan , he still has a couple for it to be finished, but should be fast.

When he's done, would you please quickly re-test that functionally it works as expected? So we can get it merged 👍🏻

Of course, @lordkrandel... @Danisan let me know when this is ready to test...

Cheers!

May 10 '24 14:05 fvz-odoo

@Danisan This still needs some improvements.

May 14 '24 11:05 jco-odoo

@fvz-odoo @lordkrandel @qdp-odoo @rugo-odoo This is ready to take-off. See also: https://github.com/odoo/enterprise/pull/59876

May 22 '24 14:05 Danisan

@robodoo r+

May 22 '24 15:05 jco-odoo