odoo icon indicating copy to clipboard operation
odoo copied to clipboard

[FW][FIX] phone_validation: colombian phone numbers

Open fw-bot opened this issue 9 months ago • 2 comments

Current behavior:

Colombian phone numbers starting with 324 are invalid.

Steps to reproduce:

parsed = phonenumbers.parse('324 1234567', 'CO') is_valid = phonenumbers.is_valid_number(parsed) is_valid == False

Cause of the issue:

Old versions of phonenumbers (external library) are not up to date with the latest colombian phone system changes

Fix:

Monkey patched the library Similar as: https://github.com/odoo/odoo/commit/b7878038e0aca885aa174ccd74be9ffd4b393a89

opw-3870579


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: odoo/odoo#164792 Forward-Port-Of: odoo/odoo#164608

fw-bot avatar May 07 '24 19:05 fw-bot

Pull request status dashboard.

robodoo avatar May 07 '24 19:05 robodoo

@ande-odoo @tde-banana-odoo cherrypicking of pull request odoo/odoo#164608 failed.

stdout:

Auto-merging addons/phone_validation/lib/phonenumbers_patch/__init__.py
CONFLICT (content): Merge conflict in addons/phone_validation/lib/phonenumbers_patch/__init__.py
Auto-merging addons/phone_validation/tests/test_phonenumbers_patch.py

stderr:

21:55:19.118433 git.c:463               trace: built-in: git cherry-pick 38e22e4e16acbb71c85269c57637a3fc91527361
error: could not apply 38e22e4e16ac... [FIX] phone_validation: colombian phone numbers
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

:warning: after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

fw-bot avatar May 07 '24 19:05 fw-bot

@robodoo r+

tde-banana-odoo avatar May 16 '24 06:05 tde-banana-odoo