odoo icon indicating copy to clipboard operation
odoo copied to clipboard

[IMP] hw_drivers: more detailed IoT version

Open lse-odoo opened this issue 1 year ago • 2 comments

Before this commit: The version of the IoT was ambiguous and was needed to be updated manually for windows. As windows IoT does not have the concept of "image" (as it depends on the installer build) the version should give this information. This information can be found in odoo release.py file

Benefit from this PR to add more details on the IoT box version to also give more information as an IoT box can be on a certain image and "code release" independantly

After this commit:

Windows IoT version:

  • Before: W22_11
  • After: W-N/A-16.0+e-20240412

IoT box version:

  • Before: 24.01
  • After: L-24.01-16.0-71bd27465

lse-odoo avatar Apr 27 '24 13:04 lse-odoo

Pull request status dashboard.

robodoo avatar Apr 27 '24 13:04 robodoo

TODO: check get_version usage, break the "update" system on the IoT box (I think) TODO2: add a manual version of the windows IoT that we will update manually. Edit the homepage so that it shows something a bit more sexy than this, L_22.1 (16.0-abcdef) or something like this easier to read)

lse-odoo avatar Apr 30 '24 12:04 lse-odoo

@odoo/rd-security hey :) just a small subprocess call in IoT to run a git command (we already use a similar structure to other git call on the IoT)

lse-odoo avatar Jun 11 '24 11:06 lse-odoo

just a small subprocess call in IoT to run a git command (we already use a similar structure to other git call on the IoT)

check_output was basically deprecated with the introduction of run in Python 3.5. Since this is a PR for Odoo 16, it's running at least 3.7.

@robodoo override=ci/security

xmo-odoo avatar Jun 11 '24 12:06 xmo-odoo