odoo icon indicating copy to clipboard operation
odoo copied to clipboard

[IMP] web_editor: floating bar and commandbar scss review

Open morm-odoo opened this issue 2 years ago • 7 comments

Prior to this PR, there was unnecessary scss for the floating toolbar and the commandbar in the web editor.

This commit also fixes some design issues like alignement for the icons in the list of the commandbar, box shadows, and the responsiveness of the floating toolbar on mobile.

In an old commit (459d4e27a860f3f0308ee0984de6f789baa65424), the toolbar dropdown had the display static added, but it causes problems to the responsiveness. This commit put the display back to dynamic on the dropdown and so, fixes the dropdown not showing on mobile because of the overflow-x on auto. The dynamic state also allows the dropdown to change direction (dropdown to dropup) when there's not enougth space for the content of the dropdown.

Would be nice to have : allow isSmall/isMobile on the all the editor toolbars (frontend and backend) After that, we can modify the layout of the toolbar for mobile, for a better behaviour and design. For now, it's just an horizontal scroll.

task-3087826

morm-odoo avatar Jan 17 '23 13:01 morm-odoo

Pull request status dashboard

robodoo avatar Jan 17 '23 13:01 robodoo

Hello @morm-odoo , what's the status? should I review? Thanks

stefanorigano avatar Feb 01 '23 09:02 stefanorigano

@stefanorigano Hello, I have to fix it on the sidebar of mass_mailing first

morm-odoo avatar Feb 01 '23 10:02 morm-odoo

@morm-odoo , update: it should be feasible for framework-editor to push a commit on top in order to expose isMobile in the xmltemplate. They will have a look :)

@dmo-odoo , here it is, thanks 👍

stefanorigano avatar Feb 01 '23 13:02 stefanorigano

@stefanorigano Can you look at my second commit, if it's an acceptable fix for the toolbar issue (linked to the display dynamic of the dropdown instead of static) in mass_mailing?

morm-odoo avatar Feb 01 '23 13:02 morm-odoo

@dmo-odoo 🚀💯

stefanorigano avatar Feb 01 '23 13:02 stefanorigano

@morm-odoo I have added a commit that should make isMobile accessible from the toolbar template. To be honest, I didn't take the time to try it, so let me know if it doesn't work and I'll have a second look.

dmo-odoo avatar Feb 01 '23 13:02 dmo-odoo

@robodoo rebase-ff r+

dmo-odoo avatar Feb 24 '23 15:02 dmo-odoo

Merge method set to rebase and fast-forward.

robodoo avatar Feb 24 '23 15:02 robodoo