odoo icon indicating copy to clipboard operation
odoo copied to clipboard

[IMP] test_lint: remove escheck test

Open SimonGenin opened this issue 3 years ago • 1 comments

As of 16.1, the ecmascript version accepted in odoo is 2022. This basically makes escheck almost irrelevant. Escheck being only able to check up to the version 2021, it can be removed safely.

SimonGenin avatar Nov 18 '22 13:11 SimonGenin

Pull request status dashboard

robodoo avatar Nov 18 '22 13:11 robodoo

Is it really safely though? At some point in the future we might start using code from next ES versions that we might not want to support?

But if the tooling doesn't even support 2022 I guess we don't really have the choice for now.

seb-odoo avatar Nov 22 '22 17:11 seb-odoo

Shouldn't the tooling in web be adapted accordingly at the same time?

Edit: odoo/odoo#105165

seb-odoo avatar Nov 22 '22 17:11 seb-odoo

@seb-odoo If escheck were to be updated, then we could keep it that's correct. So I'm not against keeping it, but currently disabling it. And yes, we should do that rather quickly to be in line with the tooling, so I guess it should be done this week whatever the solution we pick.

SimonGenin avatar Nov 23 '22 13:11 SimonGenin

@robodoo r+

jpp-odoo avatar Nov 28 '22 10:11 jpp-odoo