odoo icon indicating copy to clipboard operation
odoo copied to clipboard

[IMP] project: apply changes on Burndown chart and task kanban quickcreate

Open bastvdn opened this issue 3 years ago • 3 comments

Description of the feature this PR addresses:

  • Ordered the stages according to their sequences in the burndown chart
  • Project task kanban quickcreate: when grouping by stage, display only the projects which uses the stage in the dropdown menu

Enterprise PR: 33915

Task-3067445


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

bastvdn avatar Nov 14 '22 14:11 bastvdn

Pull request status dashboard

robodoo avatar Nov 14 '22 14:11 robodoo

seems in a draft state, please request review from JS Framework team when ready to review. Thanks

brboi avatar Jan 05 '23 13:01 brboi

Hey @auon-odoo, thanks a lot for the review, i fixed the problems you found but i still need some help with the tests. Sorry i took that much time to fix my PR, tell me if anything is wrong in my correction :)

bastvdn avatar Jan 12 '23 10:01 bastvdn

just one more question. Is there no way to ask to read_group to sort correctly the groups directly via orderby?

Polymorphe57 avatar Mar 23 '23 12:03 Polymorphe57

@auon-odoo @Polymorphe57 Thanks a lot for both of your comments, tell me what you think of this next round of changes

just one more question. Is there no way to ask to read_group to sort correctly the groups directly via orderby?

I guess i could create my own loadDataPoints function and fetch the stage sequence and use the orderby but i tried to keep the customization as simple as possible, doing a second small rpc call to fetch the sequence, id and name of the stages seemed reasonable to me. Keeping in mind that this second RPC call is only done if the page is directly reloaded which shouldn't happen that much, in the vast majority of the use cases the stages sequences will already be loaded through the action context so imo we shouldn't worry about this too much, tell me what you think :)

bastvdn avatar Mar 24 '23 14:03 bastvdn