odoo icon indicating copy to clipboard operation
odoo copied to clipboard

[FIX] base, stock, delivery: replace support datamatrix barcode printing

Open amoyaux opened this issue 3 years ago • 5 comments

This reverts commit 3ebe1185a497718a4d2a303d363a1a923dd9effe.

The code ECC200DataMatrix already exist in reportlab (that is already a dependance). Some differences:

  • ECC200DataMatrix only supports a Type 12 (44x44) C40 encoded data matrix. (214 alphanumeric characters and 14 to 27% of error correcting rate)
  • pylibdmtx support more type and add a default to 24x24. So it means a (52 characters and 20 to 35% error correcting rate). It's also smaller to display.

We consider the gain too small compare to maintain an extra lib.

*If you want to test 001234560000000018 is a valid sscc for package

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

amoyaux avatar Oct 21 '22 10:10 amoyaux

Pull request status dashboard

robodoo avatar Oct 21 '22 10:10 robodoo

FWIW there's a utility script (make_barcodes.py) which claims to still require pylibdmtx and dmtx-utils for datamatrix even though it does everything via reportlab.

Maybe it should be migrated from reportlab.graphics.barcode.dmtx to reportlab.graphics.barcode.ecc200datamatrix as well?

xmo-odoo avatar Oct 21 '22 10:10 xmo-odoo

@xmo-odoo yes, we just have some issue with ecc200datamatrix currently to fix before merging anyway. unknown

amoyaux avatar Oct 21 '22 11:10 amoyaux

@xmo-odoo https://github.com/odoo/enterprise/pull/33151/

amoyaux avatar Oct 24 '22 16:10 amoyaux

robodoo r+

Whenrow avatar Nov 24 '22 10:11 Whenrow

robodoo r+

Whenrow avatar Nov 24 '22 14:11 Whenrow

@amoyaux @Whenrow this pull request has forward-port PRs awaiting action (not merged or closed): odoo/odoo#106620

fw-bot avatar Nov 28 '22 05:11 fw-bot

@amoyaux @Whenrow this pull request has forward-port PRs awaiting action (not merged or closed): odoo/odoo#106620

fw-bot avatar Nov 29 '22 05:11 fw-bot

@amoyaux @Whenrow this pull request has forward-port PRs awaiting action (not merged or closed): odoo/odoo#106620

fw-bot avatar Nov 30 '22 05:11 fw-bot