odoo-ls icon indicating copy to clipboard operation
odoo-ls copied to clipboard

[IMP] Client side code cleaning and Python extension integration

Open delvsola opened this issue 2 years ago • 2 comments

This PR aims to provide a first fix to many errors in the client code and acts as an intermediate patch until the client side is properly refactored.

The extension also now integrates VSCode's Python extension, which means the Language Server will now be launched with the Interpreter selected for that workspace.

Changes

  • VSCode Python extension integration
  • Removal of the Python Path field in the Configuration webview.
  • Better logging in the Odoo channel.

Fixes

  • The Language Client is now properly stored and referenced through a correctly defined global variable.
  • Server stops are now properly awaited, which should hopefully fix #78 .
  • Configuration changes are now queued during server stops.
  • LanguageClient is not disposed between Configuration changes anymore, only between interpreter changes.

delvsola avatar Nov 22 '23 13:11 delvsola

@Louciole The extension crashes when starting as Disabled with the Python extension enabled

delvsola avatar Jan 08 '24 11:01 delvsola

@Louciole The extension crashes when starting as Disabled with the Python extension enabled

I can't reproduce it (either in the debug or packaged version) did you do something special?

Louciole avatar Jan 10 '24 09:01 Louciole