o-spreadsheet icon indicating copy to clipboard operation
o-spreadsheet copied to clipboard

[FIX] pivot: error on removing max number of columns/rows

Open hokolomopo opened this issue 2 months ago • 1 comments

Description

When deleting the pivot style numberOfRows or numberOfColumns in the pivot design panel, the pivot would be in error. This was because we didn't handle the cases where the content on the input was not a number, and would set NaN values.

Task: 5220970

review checklist

  • [ ] feature is organized in plugin, or UI components
  • [ ] support of duplicate sheet (deep copy)
  • [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • [ ] in model/UI: ranges are strings (to show the user)
  • [ ] undo-able commands (uses this.history.update)
  • [ ] multiuser-able commands (has inverse commands and transformations where needed)
  • [ ] new/updated/removed commands are documented
  • [ ] exportable in excel
  • [ ] translations (_t("qmsdf %s", abc))
  • [ ] unit tested
  • [ ] clean commented code
  • [ ] track breaking changes
  • [ ] doc is rebuild (npm run doc)
  • [ ] status is correct in Odoo

hokolomopo avatar Oct 29 '25 14:10 hokolomopo

Pull request status dashboard

robodoo avatar Oct 29 '25 14:10 robodoo