o-spreadsheet icon indicating copy to clipboard operation
o-spreadsheet copied to clipboard

[FIX] GenericInput: skip focus manipulation

Open rrahir opened this issue 2 months ago • 1 comments

When providing the props selectContentOnFocus, we manipulate the default behaviour of the browser (mouseDown/mouseUp) to select the full content of the input. However, half of this manipulation (prevent mouseDown default) still occured even if the props selectContentOnFocus was set to false.

Unfortunately, this cannot be properly tested as the update of the selected range on mouseDown does not seem programatically reproductible.

Task: 5206980

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

  • [ ] feature is organized in plugin, or UI components
  • [ ] support of duplicate sheet (deep copy)
  • [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • [ ] in model/UI: ranges are strings (to show the user)
  • [ ] undo-able commands (uses this.history.update)
  • [ ] multiuser-able commands (has inverse commands and transformations where needed)
  • [ ] new/updated/removed commands are documented
  • [ ] exportable in excel
  • [ ] translations (_t("qmsdf %s", abc))
  • [ ] unit tested
  • [ ] clean commented code
  • [ ] track breaking changes
  • [ ] doc is rebuild (npm run doc)
  • [ ] status is correct in Odoo

rrahir avatar Oct 29 '25 10:10 rrahir

Pull request status dashboard

robodoo avatar Oct 29 '25 10:10 robodoo