o-spreadsheet icon indicating copy to clipboard operation
o-spreadsheet copied to clipboard

[FIX] Charts: Ensure Chart js extension are loaded on chart creation

Open rrahir opened this issue 2 months ago • 4 comments

When calling the method chartToImage, the chartJs extensions might not be loaded as we load them conditionally when mounting a chart. Hence, calling ChartToImage when there are no visible charts in the viewport or if we just instantiate a model without loading a component Spreadsheet, the extensions will be missing.

Right now, the plugins/extensions are not fundamental to convert a chart to an image but this becomes problematic with the arrival of future charts (for instance Funnel).

Task: 5214007

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

  • [ ] feature is organized in plugin, or UI components
  • [ ] support of duplicate sheet (deep copy)
  • [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • [ ] in model/UI: ranges are strings (to show the user)
  • [ ] undo-able commands (uses this.history.update)
  • [ ] multiuser-able commands (has inverse commands and transformations where needed)
  • [ ] new/updated/removed commands are documented
  • [ ] exportable in excel
  • [ ] translations (_t("qmsdf %s", abc))
  • [ ] unit tested
  • [ ] clean commented code
  • [ ] track breaking changes
  • [ ] doc is rebuild (npm run doc)
  • [ ] status is correct in Odoo

rrahir avatar Oct 27 '25 14:10 rrahir

This PR targets the disabled branch odoo/o-spreadsheet:saas-18.1, it needs to be retargeted before it can be merged.

robodoo avatar Oct 27 '25 14:10 robodoo

Pull request status dashboard

robodoo avatar Oct 27 '25 14:10 robodoo

This PR targets the disabled branch odoo/o-spreadsheet:saas-18.1, it needs to be retargeted before it can be merged.

robodoo avatar Oct 27 '25 14:10 robodoo

This PR targets the disabled branch odoo/o-spreadsheet:saas-18.1, it needs to be retargeted before it can be merged.

robodoo avatar Oct 27 '25 15:10 robodoo

This PR targets the disabled branch odoo/o-spreadsheet:saas-18.1, it needs to be retargeted before it can be merged.

robodoo avatar Nov 07 '25 11:11 robodoo

@robodoo help

rrahir avatar Nov 07 '25 11:11 rrahir

Currently available commands for @rrahir:

command
help displays this help
r(eview)+ approves the PR, if it's a forwardport also approves all non-detached parents
r(eview)=<number> only approves the specified parents
fw=no does not forward-port this PR
fw=default forward-ports this PR normally
fw=skipci does not wait for a forward-port's statuses to succeed before creating the next one
fw=skipmerge does not wait for the source to be merged before creating forward ports
up to <branch> only ports this PR forward to the specified branch (included)
merge integrate the PR with a simple merge commit, using the PR description as message
rebase-merge rebases the PR on top of the target branch the integrates with a merge commit, using the PR description as message
rebase-ff rebases the PR on top of the target branch, then fast-forwards
squash squashes the PR as a single commit on the target branch, using the PR description as message
delegate+ grants approval rights to the PR author
delegate=<...> grants approval rights on this PR to the specified github users
nice only stages the PR if there's room in the batch after default PRs
default stages the PR normally
priority tries to stage this PR first, then adds default PRs if the staging has room
alone stages this PR only with other PRs of the same priority
cancel=staging automatically cancels the current staging when this PR becomes ready
override=<...> marks overridable statuses as successful
check fetches or refreshes PR metadata, resets mergebot state

Note: this help text is dynamic and will change with the state of the PR.

robodoo avatar Nov 07 '25 11:11 robodoo

robodoo fw=no

rrahir avatar Nov 07 '25 11:11 rrahir

Disabled forward-porting.

robodoo avatar Nov 07 '25 11:11 robodoo