o-spreadsheet icon indicating copy to clipboard operation
o-spreadsheet copied to clipboard

[REF] side_panel: split CF/DV panel into main and editor panel

Open rmbh-odoo opened this issue 3 months ago • 2 comments

Description:

Current behavior before PR:

  • CF and DV side panels combined the list and editor into a single panel.
  • The editor could not be opened directly.
  • Logic for the main panel and editor was mixed, reducing modularity.

Desired behavior after PR is merged:

  • Split CF and DV into separate main and editor panels.
  • Panels can be opened or replaced directly with openSidePanel / replaceSidePanel.
  • Use a store to manage the CF editor state.
  • Refactor related test cases.

Task: 4982596

review checklist

  • [ ] feature is organized in plugin, or UI components
  • [ ] support of duplicate sheet (deep copy)
  • [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • [ ] in model/UI: ranges are strings (to show the user)
  • [ ] undo-able commands (uses this.history.update)
  • [ ] multiuser-able commands (has inverse commands and transformations where needed)
  • [ ] new/updated/removed commands are documented
  • [ ] exportable in excel
  • [ ] translations (_t("qmsdf %s", abc))
  • [ ] unit tested
  • [ ] clean commented code
  • [ ] track breaking changes
  • [ ] doc is rebuild (npm run doc)
  • [ ] status is correct in Odoo

rmbh-odoo avatar Sep 22 '25 13:09 rmbh-odoo

Pull request status dashboard

robodoo avatar Sep 22 '25 13:09 robodoo

maybe the ConditionalFormattingPanel and DataValidationPanel might no longer be needed, since you’re already switching between panels directly through the side panel.

I removed the list panel because it has become useless. However, we cannot remove the main panels, since doing so would add more complexity to the preview panel. 😐

rmbh-odoo avatar Sep 26 '25 10:09 rmbh-odoo