o-spreadsheet
o-spreadsheet copied to clipboard
[REF] autofill: too much data
The autofill code isn't the easiest to read. One reason is the many "data things" (types named "Data", object keys named "data", etc.).
"data" doesn't mean anything and it certainly doesn't help the reader understand what the data actually is.
This commit tries to reduce the "data" everywhere by "unpacking" all those "data" objects and using meaningful parameters and variable names.
One key observation to achieve this: the modifiers (from the registries) are actually only generating the cell content. They were just moving around the format, style and borders for nothing.
Task: 5065180
review checklist
- [ ] feature is organized in plugin, or UI components
- [ ] support of duplicate sheet (deep copy)
- [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
- [ ] in model/UI: ranges are strings (to show the user)
- [ ] undo-able commands (uses this.history.update)
- [ ] multiuser-able commands (has inverse commands and transformations where needed)
- [ ] new/updated/removed commands are documented
- [ ] exportable in excel
- [ ] translations (_t("qmsdf %s", abc))
- [ ] unit tested
- [ ] clean commented code
- [ ] track breaking changes
- [ ] doc is rebuild (npm run doc)
- [ ] status is correct in Odoo
