o-spreadsheet
o-spreadsheet copied to clipboard
Saas 18.1 chart legend onclick dashboard v2 adrm
[IMP] chart: add mouseup event to listened events
To detect a middle mouse click on a chart, we have to use the
mouseup event, the click event is not triggered with middle
mouse button.
[FIX] charts: unregister ChartJS extension on unmount
The ChartJS extension were not unregistered when the leaving the spreadsheet. Some of them only make sense in the context of the spreadsheet, so keeping them when leaving could lead to crashes when using ChartJS elsewhere.
Task: 4636147
review checklist
- [ ] feature is organized in plugin, or UI components
- [ ] support of duplicate sheet (deep copy)
- [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
- [ ] in model/UI: ranges are strings (to show the user)
- [ ] undo-able commands (uses this.history.update)
- [ ] multiuser-able commands (has inverse commands and transformations where needed)
- [ ] new/updated/removed commands are documented
- [ ] exportable in excel
- [ ] translations (_t("qmsdf %s", abc))
- [ ] unit tested
- [ ] clean commented code
- [ ] track breaking changes
- [ ] doc is rebuild (npm run doc)
- [ ] status is correct in Odoo
@robodoo r+
@hokolomopo @rrahir because this PR has multiple commits, I need to know how to merge it:
mergeto merge directly, using the PR as merge commit messagerebase-mergeto rebase and merge, using the PR as merge commit messagerebase-ffto rebase and fast-forward
@robodoo rebase-ff
Merge method set to rebase and fast-forward.
