o-spreadsheet icon indicating copy to clipboard operation
o-spreadsheet copied to clipboard

Saas 18.1 chart legend onclick dashboard v2 adrm

Open hokolomopo opened this issue 8 months ago • 1 comments

[IMP] chart: add mouseup event to listened events

To detect a middle mouse click on a chart, we have to use the mouseup event, the click event is not triggered with middle mouse button.

[FIX] charts: unregister ChartJS extension on unmount

The ChartJS extension were not unregistered when the leaving the spreadsheet. Some of them only make sense in the context of the spreadsheet, so keeping them when leaving could lead to crashes when using ChartJS elsewhere.

Task: 4636147

review checklist

  • [ ] feature is organized in plugin, or UI components
  • [ ] support of duplicate sheet (deep copy)
  • [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • [ ] in model/UI: ranges are strings (to show the user)
  • [ ] undo-able commands (uses this.history.update)
  • [ ] multiuser-able commands (has inverse commands and transformations where needed)
  • [ ] new/updated/removed commands are documented
  • [ ] exportable in excel
  • [ ] translations (_t("qmsdf %s", abc))
  • [ ] unit tested
  • [ ] clean commented code
  • [ ] track breaking changes
  • [ ] doc is rebuild (npm run doc)
  • [ ] status is correct in Odoo

hokolomopo avatar Apr 09 '25 11:04 hokolomopo

Pull request status dashboard

robodoo avatar Apr 09 '25 11:04 robodoo

@robodoo r+

rrahir avatar May 07 '25 13:05 rrahir

@hokolomopo @rrahir because this PR has multiple commits, I need to know how to merge it:

  • merge to merge directly, using the PR as merge commit message
  • rebase-merge to rebase and merge, using the PR as merge commit message
  • rebase-ff to rebase and fast-forward

robodoo avatar May 07 '25 13:05 robodoo

@robodoo rebase-ff

rrahir avatar May 07 '25 13:05 rrahir

Merge method set to rebase and fast-forward.

robodoo avatar May 07 '25 13:05 robodoo