o-spreadsheet icon indicating copy to clipboard operation
o-spreadsheet copied to clipboard

[FIX] selection_input: fix range deletion

Open Rachico opened this issue 9 months ago • 1 comments

Prior to this commit, clicking the trash icon next to a range in DV/CF did not remove the range due to a missing event handler. This bug was introduced by this commit: https://github.com/odoo/o-spreadsheet/pull/5027/commits/f64e482ec0935b1243dd6a67fabbc21f886beb9e

This commit ensures that the deletion action is correctly triggered, allowing a proper management of CF/DV rules

Steps to reproduce:

  • Create a DV/CF rule
  • Add a new range (valid or invalid)
  • Click on the trash icon next to the range
  • Nothing happens

Task: 4589387

review checklist

  • [ ] feature is organized in plugin, or UI components
  • [ ] support of duplicate sheet (deep copy)
  • [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • [ ] in model/UI: ranges are strings (to show the user)
  • [ ] undo-able commands (uses this.history.update)
  • [ ] multiuser-able commands (has inverse commands and transformations where needed)
  • [ ] new/updated/removed commands are documented
  • [ ] exportable in excel
  • [ ] translations (_t("qmsdf %s", abc))
  • [ ] unit tested
  • [ ] clean commented code
  • [ ] track breaking changes
  • [ ] doc is rebuild (npm run doc)
  • [ ] status is correct in Odoo

Rachico avatar Mar 17 '25 09:03 Rachico

Pull request status dashboard

robodoo avatar Mar 17 '25 09:03 robodoo

the commit hash you refer to doesn't belong to any active branch. Could you update it to the hash present in branch saas-18.2?

rrahir avatar Apr 22 '25 07:04 rrahir

@robodoo r+

rrahir avatar May 02 '25 09:05 rrahir