o-spreadsheet icon indicating copy to clipboard operation
o-spreadsheet copied to clipboard

[IMP] figures: add anchor to figures

Open fdamhaut opened this issue 1 year ago • 4 comments

Description:

[IMP] figures: add anchor to figures

Add possibilities for chart to be anchored to the top-left corner cell. If a cell is anchored, it will be moving with the cell on modification of the sheet (i.e. col/row addition/deletion).

The figure can still have a fixed position, this will act as if the anchor is placed in the left-most, top-most cell.

Task: 4189170

review checklist

  • [ ] feature is organized in plugin, or UI components
  • [ ] support of duplicate sheet (deep copy)
  • [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • [ ] in model/UI: ranges are strings (to show the user)
  • [ ] undo-able commands (uses this.history.update)
  • [ ] multiuser-able commands (has inverse commands and transformations where needed)
  • [ ] new/updated/removed commands are documented
  • [ ] exportable in excel
  • [ ] translations (_t("qmsdf %s", abc))
  • [ ] unit tested
  • [ ] clean commented code
  • [ ] track breaking changes
  • [ ] doc is rebuild (npm run doc)
  • [ ] status is correct in Odoo

fdamhaut avatar Dec 16 '24 13:12 fdamhaut

Pull request status dashboard

robodoo avatar Dec 16 '24 13:12 robodoo

@fdamhaut I forgot a point, we should have some tests that cover the functional issues I mentionned in the task pad (deleting the anchor header and the "MOVE_COLUMNS_ROWS" issue

rrahir avatar Mar 21 '25 14:03 rrahir

@fdamhaut I forgot a point, we should have some tests that cover the functional issues I mentionned in the task pad (deleting the anchor header and the "MOVE_COLUMNS_ROWS" issue

I already added some test in figures_plugin.test for that L457-830

fdamhaut avatar Mar 24 '25 09:03 fdamhaut

figures_plugin.test

SOrry I completely missed it :'(

rrahir avatar Mar 26 '25 13:03 rrahir

@robodoo r+

rrahir avatar Apr 14 '25 11:04 rrahir