o-spreadsheet icon indicating copy to clipboard operation
o-spreadsheet copied to clipboard

[FIX] charts: fix padding computation

Open anhe-odoo opened this issue 1 year ago • 3 comments

Task Description

Since the chart design refactoring, the value of the title is now stored in an object as chart.title.text, instead of the previous chart.title. During the introduction of the design customization, the computation of the padding hasn't been updated, considering now that the title is alsway defined, which is not the case. This PR aims to thix this behavior by changing the condition used in the padding computation.

Related Task:

  • Task: 0

review checklist

  • [ ] feature is organized in plugin, or UI components
  • [ ] support of duplicate sheet (deep copy)
  • [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • [ ] in model/UI: ranges are strings (to show the user)
  • [ ] undo-able commands (uses this.history.update)
  • [ ] multiuser-able commands (has inverse commands and transformations where needed)
  • [ ] new/updated/removed commands are documented
  • [ ] exportable in excel
  • [ ] translations (_t("qmsdf %s", abc))
  • [ ] unit tested
  • [ ] clean commented code
  • [ ] track breaking changes
  • [ ] doc is rebuild (npm run doc)
  • [ ] status is correct in Odoo

anhe-odoo avatar Jun 10 '24 05:06 anhe-odoo

Pull request status dashboard

robodoo avatar Jun 10 '24 05:06 robodoo

@rrahir : here is the Odoo version : https://github.com/odoo/odoo/pull/168639

anhe-odoo avatar Jun 10 '24 07:06 anhe-odoo

@anhe-odoo the target branch 'saas-17.3' has been disabled, you may want to close this PR.

robodoo avatar Jul 18 '24 14:07 robodoo

@anhe-odoo the target branch 'saas-17.4' has been disabled, you may want to close this PR.

robodoo avatar Feb 10 '25 06:02 robodoo