o-spreadsheet icon indicating copy to clipboard operation
o-spreadsheet copied to clipboard

[FIX] Notificiation: set a default notification store

Open rrahir opened this issue 9 months ago • 1 comments

Following the introduction of stores, the minimal setup has evolved as it requires to instanciate a some stores before the creation of a spreadsheet app. The documentation was not updated accordingly.

More specifically, the only store that we required to instantiate manually was the NotificationStore and we had to add it to the App env as well. These last step are a pain for developpers that only want to set a quick and minimal integration.

This commit sets default notification methods (raiseError, notifyUser, askConfirmation) which can be updated by calling NotificationStore.update.

Task: 3918013

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

  • [ ] feature is organized in plugin, or UI components
  • [ ] support of duplicate sheet (deep copy)
  • [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • [ ] in model/UI: ranges are strings (to show the user)
  • [ ] undo-able commands (uses this.history.update)
  • [ ] multiuser-able commands (has inverse commands and transformations where needed)
  • [ ] new/updated/removed commands are documented
  • [ ] exportable in excel
  • [ ] translations (_t("qmsdf %s", abc))
  • [ ] unit tested
  • [ ] clean commented code
  • [ ] track breaking changes
  • [ ] doc is rebuild (npm run doc)
  • [ ] status is correct in Odoo

rrahir avatar May 08 '24 13:05 rrahir

@LucasLefevre Moved it to master and adapted the willUpdateprops hook @hokolomopo I put the call to the env back even though I fear it could still disappear in the future. But at least it alleviates this diff :p

rrahir avatar May 30 '24 12:05 rrahir