o-spreadsheet icon indicating copy to clipboard operation
o-spreadsheet copied to clipboard

[FIX] functions: cast to matrix

Open LucasLefevre opened this issue 9 months ago • 1 comments

=SUMIF(CHOOSECOLS(A1,-1),A2) crashes because visitMatchingRanges blindly index args[0][0] even if args[0] is not a matrix. In this case, it's an error object because CHOOSECOLS(A1,-1) is not valid.

Task: 3918882

Description:

description of this task, what is implemented and why it is implemented that way.

Task: : TASK_ID

review checklist

  • [ ] feature is organized in plugin, or UI components
  • [ ] support of duplicate sheet (deep copy)
  • [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • [ ] in model/UI: ranges are strings (to show the user)
  • [ ] undo-able commands (uses this.history.update)
  • [ ] multiuser-able commands (has inverse commands and transformations where needed)
  • [ ] new/updated/removed commands are documented
  • [ ] exportable in excel
  • [ ] translations (_t("qmsdf %s", abc))
  • [ ] unit tested
  • [ ] clean commented code
  • [ ] track breaking changes
  • [ ] doc is rebuild (npm run doc)
  • [ ] status is correct in Odoo

LucasLefevre avatar May 08 '24 11:05 LucasLefevre

@LucasLefevre are you okay to fixup the suggestion ?

laa-odoo avatar May 16 '24 11:05 laa-odoo

the ref should be done in master

rrahir avatar May 27 '24 13:05 rrahir

the ref should be done in master

Should be okay

laa-odoo avatar May 30 '24 07:05 laa-odoo

@robodoo r+

rrahir avatar May 30 '24 12:05 rrahir

@LucasLefevre @rrahir because this PR has multiple commits, I need to know how to merge it:

  • merge to merge directly, using the PR as merge commit message
  • rebase-merge to rebase and merge, using the PR as merge commit message
  • rebase-ff to rebase and fast-forward

robodoo avatar May 30 '24 13:05 robodoo

@robodoo rebase-ff

rrahir avatar May 30 '24 13:05 rrahir

Merge method set to rebase and fast-forward.

robodoo avatar May 30 '24 13:05 robodoo