o-spreadsheet icon indicating copy to clipboard operation
o-spreadsheet copied to clipboard

[REM] merge: remove useless topLeft attribute from Merge interface

Open Rachico opened this issue 9 months ago • 1 comments

Description:

merge: remove useless topLeft attribute from Merge interface.

Context

The "topLeft" attribute in the Merge interface was used as a shortcut to get the top left position of the merge zone. However, this was creating redundant code.

Task: 3912050

review checklist

  • [ ] feature is organized in plugin, or UI components
  • [ ] support of duplicate sheet (deep copy)
  • [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • [ ] in model/UI: ranges are strings (to show the user)
  • [ ] undo-able commands (uses this.history.update)
  • [ ] multiuser-able commands (has inverse commands and transformations where needed)
  • [ ] new/updated/removed commands are documented
  • [ ] exportable in excel
  • [ ] translations (_t("qmsdf %s", abc))
  • [ ] unit tested
  • [ ] clean commented code
  • [ ] track breaking changes
  • [ ] doc is rebuild (npm run doc)
  • [ ] status is correct in Odoo

Rachico avatar May 06 '24 13:05 Rachico

@robodoo r+

rrahir avatar May 15 '24 13:05 rrahir