o-spreadsheet icon indicating copy to clipboard operation
o-spreadsheet copied to clipboard

Master recompute zones everywhere laa

Open laa-odoo opened this issue 10 months ago • 1 comments

[REF] recompute zones: use recomputeZones on missing places

For performance reasons, this commit proposes to add recomputeZonnes wherever we cross all the elements of a list of zones.

[REF] zones helper: remove unused helpers

Task: 3893550

review checklist

  • [ ] feature is organized in plugin, or UI components
  • [ ] support of duplicate sheet (deep copy)
  • [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • [ ] in model/UI: ranges are strings (to show the user)
  • [ ] undo-able commands (uses this.history.update)
  • [ ] multiuser-able commands (has inverse commands and transformations where needed)
  • [ ] new/updated/removed commands are documented
  • [ ] exportable in excel
  • [ ] translations (_t("qmsdf %s", abc))
  • [ ] unit tested
  • [ ] clean commented code
  • [ ] track breaking changes
  • [ ] doc is rebuild (npm run doc)
  • [ ] status is correct in Odoo

laa-odoo avatar Apr 25 '24 13:04 laa-odoo

A little rebase is in order :/ I think we could add the use of recompute zone in a couple more places as well but there might be a reason you didn't. I'm thinking of

  • DataValidationPlugin -> handle "DELETE_CONTENT"
  • AutomaticSumPlugin -> handle "SUM_SELECTION"
  • MergePlugin -> handle "ADD_MERGE","REMOVE_MERGE" What do you think of those?

Ok with DELETE_CONTENT on DataValidationPlugin

For the others, the behavior can functionally change. So no

laa-odoo avatar May 16 '24 13:05 laa-odoo

@robodoo rebase-ff

rrahir avatar May 17 '24 16:05 rrahir

Merge method set to rebase and fast-forward.

robodoo avatar May 17 '24 16:05 robodoo

Off we go then :D @robodoo r+

rrahir avatar May 17 '24 16:05 rrahir