o-spreadsheet icon indicating copy to clipboard operation
o-spreadsheet copied to clipboard

[FIX] FigureComponent: only propagate CTRL + Y/Z

Open dhrp-odoo opened this issue 10 months ago • 1 comments

Description:

Previously, when a figure was selected, And pressing CTRL + A would select all rows and columns in the sheet, and pressing the Delete key would delete the selected figure. This occurred because all key events were bubbling up to the grid component.

This PR now fixes the problem by only passing key events for CTRL + Y/Z to the grid element.

Task: : 3863300

review checklist

  • [ ] feature is organized in plugin, or UI components
  • [ ] support of duplicate sheet (deep copy)
  • [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • [ ] in model/UI: ranges are strings (to show the user)
  • [ ] undo-able commands (uses this.history.update)
  • [ ] multiuser-able commands (has inverse commands and transformations where needed)
  • [ ] new/updated/removed commands are documented
  • [ ] exportable in excel
  • [ ] translations (_t("qmsdf %s", abc))
  • [ ] unit tested
  • [ ] clean commented code
  • [ ] track breaking changes
  • [ ] doc is rebuild (npm run doc)
  • [ ] status is correct in Odoo

dhrp-odoo avatar Apr 17 '24 08:04 dhrp-odoo

@robodoo rebase-ff r+

@dhrp-odoo Thanks a lot ! :)

rrahir avatar May 27 '24 15:05 rrahir

Merge method set to rebase and fast-forward.

robodoo avatar May 27 '24 15:05 robodoo