o-spreadsheet
o-spreadsheet copied to clipboard
[IMP] highlight: add drag & drop to array formula highlight
[IMP] highlight: add drag & drop to array formula highlight
With this commit, it is now possible to drag & drop an array formula by clicking on its highlight.
[IMP] highlight: improve border hitbox
The hitbox for the borders of the highlight was not very well placed. There was some margins computations, I'm assuming they were there to avoid overlapping with the highlight corners but they we both wrong (there was overlap) and useless (the corner is above the border).
The highlight border was also not centered on the cell border, and was quite small, making it hard to click.
This commit removed the "margins", and widened and centered the borders.
[REF] highlight: rename Highlight component:
The component that handle highlight's UI interactions is named
Highlight
, which is the same as the type Highlight
. This is annoying
because we always end up importing the wrong Highlight
, and need
named imports if we want to use both the type and the component in a
file.
This commit renames the component to HighlightOverlay
Task: : 3869873
review checklist
- [ ] feature is organized in plugin, or UI components
- [ ] support of duplicate sheet (deep copy)
- [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
- [ ] in model/UI: ranges are strings (to show the user)
- [ ] undo-able commands (uses this.history.update)
- [ ] multiuser-able commands (has inverse commands and transformations where needed)
- [ ] new/updated/removed commands are documented
- [ ] exportable in excel
- [ ] translations (_t("qmsdf %s", abc))
- [ ] unit tested
- [ ] clean commented code
- [ ] track breaking changes
- [ ] doc is rebuild (npm run doc)
- [ ] status is correct in Odoo