o-spreadsheet icon indicating copy to clipboard operation
o-spreadsheet copied to clipboard

[REF] compilation_parameters: remove useless parameter

Open laa-odoo opened this issue 1 year ago • 1 comments

Description:

next to https://github.com/odoo/o-spreadsheet/pull/3742

Since we treat the form of the arguments (matrix or not) before each sub-formula, we can remove the code doing the same thing across reference reading.

review checklist

  • [ ] feature is organized in plugin, or UI components
  • [ ] support of duplicate sheet (deep copy)
  • [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • [ ] in model/UI: ranges are strings (to show the user)
  • [ ] undo-able commands (uses this.history.update)
  • [ ] multiuser-able commands (has inverse commands and transformations where needed)
  • [ ] new/updated/removed commands are documented
  • [ ] exportable in excel
  • [ ] translations (_t("qmsdf %s", abc))
  • [ ] unit tested
  • [ ] clean commented code
  • [ ] track breaking changes
  • [ ] doc is rebuild (npm run doc)
  • [ ] status is correct in Odoo

laa-odoo avatar Feb 26 '24 15:02 laa-odoo

This PR targets the un-managed branch odoo/o-spreadsheet:saas-17.1-fix-evaluation-type-guard-laa, it needs to be retargeted before it can be merged.

robodoo avatar Feb 26 '24 15:02 robodoo