o-spreadsheet icon indicating copy to clipboard operation
o-spreadsheet copied to clipboard

[REF] edition: force consistency in the plugin state

Open rrahir opened this issue 2 years ago • 1 comments

Description:

[REF] edition: force consistency in the plugin state The plugin internal state is globally inconsistent. Some values are properly resetted when start/stopping the edition, some are not. Furthermore, functions are designed such that we need to call fucntions in a very specific order in order not to crash [1].

This commit forces a stronger typing in the plugin.

[1] https://github.com/odoo/o-spreadsheet/pull/1739#discussion_r1041233112

Odoo task ID : TASK_ID

review checklist

  • [ ] feature is organized in plugin, or UI components
  • [ ] support of duplicate sheet (deep copy)
  • [ ] in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • [ ] in model/UI: ranges are strings (to show the user)
  • [ ] undo-able commands (uses this.history.update)
  • [ ] multiuser-able commands (has inverse commands and transformations where needed)
  • [ ] new/updated/removed commands are documented
  • [ ] exportable in excel
  • [ ] translations (_lt("qmsdf %s", abc))
  • [ ] unit tested
  • [ ] clean commented code
  • [ ] track breaking changes
  • [ ] doc is rebuild (npm run doc)
  • [ ] status is correct in Odoo

rrahir avatar Dec 17 '22 21:12 rrahir