odoo
[ADD] accounting/l10n_uy: uruguay
Hi @fvz-odoo, thank you so much for your helpful review! I implemented most of your suggestions in fcc950e, as well as added missing images, and added a couple of suggestions of my own.
@rps-odoo can you help me with the following:
- DGI Main Branch Code description
- Specify that in Uruguay CAEs are needed and must be uploaded in Uruware
- Electronic option is missing here with its explanation
- Rephrase this paragraph to explain the manual option
- Expand the explanation to all 4
- Need navigation instructions for electronic invoice
- Need navigation instructions to where taxes can be reviewed
- Need navigation instructions for where can users can manage document types
Thank you!
Hi @ewa-odoo, requesting your review before opening this PR up from draft, thank you!
Thanks @fvz-odoo! I implemented each of your resolved suggestions in https://github.com/odoo/documentation/commit/ee4c2d94dfcedee1b4572c5ad9a3385297457e93, thank you!
@ewa-odoo can you help me with this remaining suggestion: https://github.com/odoo/documentation/pull/9849#discussion_r1714242710 🙏
Thanks @fvz-odoo! Implemented in https://github.com/odoo/documentation/pull/9849#discussion_r1725467858
Thanks @fvz-odoo! Implemented in #9849 (comment)
Thanks @samueljlieber this LGTM now. We can merge this once the edi module gets merged, thanks!
Cheers!
Fernando
@ewa-odoo
https://github.com/odoo/documentation/commit/4d56fdc8b5f1ed983be7364849482d3a12735fb4 Rebased to latest and opened this PR up for review!
@odoo/localizations-doc-review this PR is ready for your review! Please consider this PR a priority as the localization is going live this week! Thanks in advance!
https://github.com/odoo/documentation/commit/bfb0940ecd84623ace1dae7a821c78e22c55615d Implemented @fvz-odoo final changes :)
@samueljlieber Hey Sam, thanks for reaching out. I'm passing this straight on to the final review from @auva-odoo to hopefully get it live by EOD Monday :)
Thanks @dade-odoo and @auva-odoo! https://github.com/odoo/documentation/commit/53653accbc86cccfd27833b1dd3ff1d58ee19eb8 I implemented two more very small changes from @fvz-odoo :
- https://github.com/odoo/documentation/pull/9849/files#r1746330094
- https://github.com/odoo/documentation/pull/9849/files#r1746330727
Thank you so much @auva-odoo for your helpful review! I implemented all of your current suggestions in https://github.com/odoo/documentation/commit/a507a526b7737198df4f05a559f9381662bdfc58, I will keep an eye out if any more come through!
Thank you so much @auva-odoo for your thorough and very helpful feedback! I implemented your final changes in https://github.com/odoo/documentation/commit/72a3fda61e3f57a057df5d2775a88f52ace4cb9f. Once the checks pass I will merge this PR! 🚀