documentation icon indicating copy to clipboard operation
documentation copied to clipboard

[IMP] Payroll: add necessary contract modules

Open larm-odoo opened this issue 1 year ago • 4 comments

Updating this doc to add a necessary module that must be installed. This was requested on this project card.

This change will go form 15 up to master, as this infomration is necessary in all versions.

larm-odoo avatar May 13 '24 18:05 larm-odoo

Hi @hojo-odoo - this is ready for a peer review. Please note, I only added an important block in the Contract Details tab section of the doc, and I updated issues that appeared on the Linter (not using "in order to" and fixed all instances of "Kanban").

larm-odoo avatar May 13 '24 18:05 larm-odoo

Hi @ksc-odoo - this is ready for a final review! This is similar to the other doc you reviewed- adding the same info to this doc, as it is necessary here as well.

larm-odoo avatar May 15 '24 14:05 larm-odoo

Thank you @ksc-odoo! I decided to just go ahead and make those formatting edits, so I made sure everything after a colon was lower case, and I added the new icons as well. I think that's all the formatting issues that were from our new rules. I also made all the requested edits and updates. Ready for another look!

larm-odoo avatar May 15 '24 17:05 larm-odoo

Hi @ksc-odoo - thank you again for your very thorough review. I want to take a moment to apologize, because I honestly couldn't understand why my info was off or wrong- and you had so many correctoins to do. This PR was written to only add the needed module info (it was requested ot be added from a product owner- I know you saw the other docs I added this to, because they all had the same info in them).

My intention was just to add that small part to this doc- a simple 2 point doc. So I did not go in and do all the updates as I normally would. I feel I should have been much more clear on that- because I could have done the module doc (for 2 pts) and then a 3 point doc to update the instrucitons (I al slowly learning how to gamify with points- it's not in my nature, so this is not easy for me, lol).

Also, when I originally wrote the contracts doc, it was for 14- then they were ported up to master. This year, I decided to do all the 17 updates FIRST, then go back and do 16 updates. Only after that would I do any 15 updates, since that version was going to go away soon, and most likely not beofre I did all the updates for the newer 2 versions.

So I just wanted to explain myself because I felt SO BAD that you had all these comments- and I honestly didn't know why things/images looked differet than the runbots I had originaly used- since I was only focusing on adding that admonition on the module. So, thank you for being so thorough- and please accept both my explanation and aplogy for all the work you did editing this doc- it was not my intention to have you do so much work!

larm-odoo avatar May 16 '24 16:05 larm-odoo

Oh, and this is ready for another look @ksc-odoo =D

larm-odoo avatar May 16 '24 16:05 larm-odoo

Hi @samueljlieber - this is ready for a tech review. Thanks!

larm-odoo avatar May 20 '24 16:05 larm-odoo

@larm-odoo @samueljlieber this pull request has forward-port PRs awaiting action (not merged or closed):

  • odoo/documentation#9469
  • odoo/documentation#9470
  • odoo/documentation#9471
  • odoo/documentation#9472

fw-bot avatar May 28 '24 05:05 fw-bot

@larm-odoo @samueljlieber this pull request has forward-port PRs awaiting action (not merged or closed):

  • odoo/documentation#9472

fw-bot avatar May 29 '24 05:05 fw-bot

@larm-odoo @samueljlieber this pull request has forward-port PRs awaiting action (not merged or closed):

  • odoo/documentation#9472

fw-bot avatar May 30 '24 05:05 fw-bot

@larm-odoo @samueljlieber this pull request has forward-port PRs awaiting action (not merged or closed):

  • odoo/documentation#9472

fw-bot avatar May 31 '24 05:05 fw-bot

@larm-odoo @samueljlieber this pull request has forward-port PRs awaiting action (not merged or closed):

  • odoo/documentation#9589
  • odoo/documentation#9591
  • odoo/documentation#9595

fw-bot avatar Jun 01 '24 05:06 fw-bot

@larm-odoo @samueljlieber this pull request has forward-port PRs awaiting action (not merged or closed):

  • odoo/documentation#9589

fw-bot avatar Jun 02 '24 05:06 fw-bot

@larm-odoo @samueljlieber this pull request has forward-port PRs awaiting action (not merged or closed):

  • odoo/documentation#9589

fw-bot avatar Jun 03 '24 05:06 fw-bot

@larm-odoo @samueljlieber this pull request has forward-port PRs awaiting action (not merged or closed):

  • odoo/documentation#9589

fw-bot avatar Jun 05 '24 05:06 fw-bot