odoo
[IMP] accounting/l10n_br: electronic invoicing & tax computation flow
…n flow
With the addition of l10n_br_{avatax,edi,edi_sale}_services to the previous modules, now electronic invoices and tax computation for services can be created from Odoo through Avalara.
PR that includes these features: https://github.com/odoo/enterprise/pull/57868
This PR includes the necessary information to use these new modules - configuration and workflows.
G-Folder with new images: https://drive.google.com/drive/folders/1rCkyiYnWslzlQ7Oxb3IJC0-TeiWrQOwb?usp=sharing
Hey @samueljlieber thanks for the changes and the review. Just as a heads up the PRs that introduce this new feature were merged Today:
- https://github.com/odoo/odoo/pull/156017
- https://github.com/odoo/enterprise/pull/57868
And it will be available for customers starting next Monday, 22nd. Thanks! cc' @fvz-odoo @ren-odoo @masi-odoo
Hello @samueljlieber do you know if we can ping someone for this review? Thanks!
Hello @samueljlieber do you know if we can ping someone for this review? Thanks!
Sorry about that @vbe-odoo, this PR got hung up and needed to be refreshed. The reviewers have been auto-tagged now 👍
8ce66e6 Thank you for your thorough review @dade-odoo, I implemented each of your suggestions in 8ce66e6. As well as commented on your point about updated modules in saas-17.2.
Hello, @dade-odoo do you have more suggestions for this PR? If not, do you think we can move forward with this? As we already have this feature merged and available for customers.
Thank you! cc' @samueljlieber @ren-odoo @masi-odoo @fvz-odoo
Hi @vbe-odoo @samueljlieber ! My apologies, I missed Sam's message on the 29th and then was out of office since the 1st. I'm still not convinced that the red boxes on the product configuration screenshot are necessary, but I'll let the final reviewer make that decision :) Thanks again for adding this and I'll request the final review :)
Hi @auva-odoo, thank you for your helpful and insightful review! In 3f8068e I addressed all of your resolved suggestions as well as fixed any of the instances where "Avatax" was lowercase, and removed the GDrive comment from the commit message.
I left a couple suggestions resolved as I will need @vbe-odoo's thoughts on them.
Also, I just reviewed this https://github.com/odoo/documentation/pull/9341 PR on the AvaTax implementation in Odoo 17.0+, I suggested that we should link to this brazil.rst fiscal localization doc for local specific AvaTax instructions. I believe we are missing some of the AvaTax Brazil modules in this PR, @vbe-odoo can you confirm?
Thanks all!
Hi @auva-odoo, that sounds good to me– I believe VBE is also OOO. So in 091c084 I decided to add the Accounting Reports module to the modules list and removed the two images that had markup.
I think this PR is good to go, and this doc can be improved later once VBE is back. Thanks again!
Hi @samueljlieber indeed VBE is OOO so let's move forward with this PR then.
Thank you.
