documentation icon indicating copy to clipboard operation
documentation copied to clipboard

[IMP] accounting/l10n_ar: liquidity product direct sales

Open rps-odoo opened this issue 1 year ago • 3 comments

Link to GDrive images folder: https://drive.google.com/drive/folders/1qWtbGewR3LxDKs21QpMEPhCKEovVyoKx?usp=drive_link

rps-odoo avatar Mar 05 '24 16:03 rps-odoo

Thank you @rps-odoo, I implemented your changes in 3a9bef8. This PR should now be ready for review, thanks in advance! 🙏

samueljlieber avatar Mar 14 '24 13:03 samueljlieber

Thank you for your review @xpl-odoo, I implemented most of your changes in https://github.com/odoo/documentation/commit/f25a7195837ae8f78c050d72d4ac81effde3c2e7.

@rps-odoo can you help me address the remaining suggestions?

  • Unclear if all document types should be activated or if it depends on the needs of the user
  • The toggle don't work for me (17.0 runbot, 17.1 test db, base with the required modules installed, but not the full configuration)
  • I don't see those documents, but I didn't fully configure my base runbot (17.0) and test db (17.1) aven though I should have installed all the proper modules. Since you mention installing the AR e-invoicing module is required, you could also say it should be configured? Or not mention the installation at all.
  • The meaning is a bit unclear, not sure I got it right

I will update the PR once these ^ have been addressed, thank you!

samueljlieber avatar Mar 25 '24 13:03 samueljlieber

Thank you @rps-odoo, I implemented your feedback to XPL's comments in 403d55c.

samueljlieber avatar Mar 28 '24 17:03 samueljlieber

@robodoo delegate=samueljlieber

xpl-odoo avatar Mar 29 '24 13:03 xpl-odoo

@robodoo r+

samueljlieber avatar Mar 29 '24 14:03 samueljlieber