documentation icon indicating copy to clipboard operation
documentation copied to clipboard

[IMP] MRP: edited/updated Semi-Finished products doc v15

Open weka-one opened this issue 3 years ago • 3 comments

Replaced the images, and rewrote the content to ensure it's consistent and up to date.

weka-one avatar Oct 04 '22 21:10 weka-one

@mivu-odoo I incorporated the requested changes. Please take another look whenever you get the chance. Thank you!

weka-one avatar Oct 06 '22 15:10 weka-one

@StraubCreative This PR is ready for you to review whenever you get the chance. I rewrote a lot of this content/replaced the images to make sure that it's up to date.

Thank you!

weka-one avatar Oct 06 '22 18:10 weka-one

@weka-odoo quick follow up— I had to solve a merge conflict that showed up as a result of #2983 which wiped all trailing whitespaces across the entire repo, including this file. You should be all set on 220e1c8, please make sure you git pull --rebase before you start addressing the CR's 👍

StraubCreative avatar Dec 02 '22 01:12 StraubCreative

Hi @odoo/doc-review 👋 This article about sub-assemblies is ready for your review. Thank you 🙂

StraubCreative avatar Dec 30 '22 02:12 StraubCreative

@robodoo r+

StraubCreative avatar Jan 05 '23 17:01 StraubCreative

I'm sorry, @StraubCreative. I'm afraid I can't do that.

robodoo avatar Jan 05 '23 17:01 robodoo

@AntoineVDV should be good to go unless you catch anything else. Please advise weka-odoo will not be able to FP the chain once the merge command is issued. Will need you to do it please or can delegate to me or @mivu-odoo if that's possible 🙂

StraubCreative avatar Jan 05 '23 17:01 StraubCreative

Hi @StraubCreative, the r+ is already delegated to you, and so will the forward-port PRs. ;)

Note that the forward-port bot is currently broken (I hope for a fix next week :crossed_fingers:). It will create the forward-port PRs, but it will also rebase them on a commit from December 2... This highly increases the chances of having a "conflict". If that happens in the fwp PR for saas-15.2, run git fetch origin saas-15.2 <the-fwp-branch> && git switch <the-fwp-branch> && git reset --hard origin/saas-15.2 && git cherry-pick ea43afc792b94de938c0f0cb8546a6a22675a7f1 && git push --force-with-lease to fix it.

AntoineVDV avatar Jan 06 '23 09:01 AntoineVDV

@robodoo r+

StraubCreative avatar Jan 13 '23 00:01 StraubCreative

I'm sorry, @StraubCreative. I'm afraid I can't do that.

robodoo avatar Jan 13 '23 00:01 robodoo

@StraubCreative My bad; I thought you were the author of the PR.

@robodoo r+

PS: The issue with the forward-port bot has been resolved.

AntoineVDV avatar Jan 13 '23 10:01 AntoineVDV

@weka-odoo @AntoineVDV this pull request has forward-port PRs awaiting action (not merged or closed): odoo/documentation#3334

  • odoo/documentation#3337
  • odoo/documentation#3339
  • odoo/documentation#3340

fw-bot avatar Jan 17 '23 05:01 fw-bot