documentation
documentation copied to clipboard
odoo
[IMP] iot: Add part regarding screen
Add more details as of how to connect a screen to the IoT box and how it can be used.
OPW-2962462
Several things that I would like to be reviewed on (as I'm not used to do documentation PR):
- Should I remove the part in which I "advertise" a version 15 feature and add it manually in the forward port ? ANV do think so but I would like a second opinion to confirm what he say because I tend to disagree with him on that (even if I got his point and do understand and agree to it to some degree)
- I did on purpose not add the translations and didn't use
pngquanton my picture. I will do this at the end when reviewers will agree with the content - I did took inspiration of other IoT devices documentation to write this one to be consistent with the other documentation of the IoT
- I know that we are not very friend with picture in the documentation. Let me know which one you think are irrelevant
Hello @lse-odoo, I hope you're doing great!
I've reviewed the part that concerns the pos, and it looks fine to me :) NB: Idk if the IoT part is correct as @mivu-odoo is in charge, so I let it to her :)
Good day to you,
@mivu-odoo Thank you for your comment and review. Note that I did needed to fix some of your suggestions (generally because the indentation was wrong so it was triggering warning at build time). I did create a second commit to that you can see the correction that I did apply to your suggestion (I hope it will be useful to learn for you too :) ). If you agree with my proposed corrections, I will merge/squash both commits and we are good to go!
@mivu-odoo commits squashed! Should I contact someone in particular to merge it in the documentation ?
@lse-odoo I'll go ahead and tag the @odoo/doc-review team for you! They will look over the PR and merge the branch :smile_cat:
@AntoineVDV done as you asked! I did indeed forgot about pngquant (even if i mentioned on the matter previously). is there something that I need to change ?