documentation icon indicating copy to clipboard operation
documentation copied to clipboard

[add] discuss: specific email server from

Open samueljlieber opened this issue 3 years ago • 7 comments

Manual cherry pick of https://github.com/odoo/documentation/pull/2626 which is a follow up from https://github.com/odoo/documentation/pull/1449.

Odoo 15.0 introduced the ability to use a specific email server depending on the "From". So a new section "Set up different outgoing servers in a multi-company environment" has been added in the documentation. This explains the logic applied to select the right email server.

samueljlieber avatar Aug 24 '22 14:08 samueljlieber

@cth-odoo @tiku-odoo @std-odoo @AntoineVDV Let's continue content and technical review here for this PR.

@samueljlieber took all of the change requests from the prior PR (#1449) and moved them over to this new feature branch. Now we have a clean commit history and no more technical hiccups.

Please take a look at what we have here, and let Sam know if any changes are needed in the content and he will take care of making those updates. Afterwards we can ship to final reviews.

Thank you 🙏

StraubCreative avatar Aug 24 '22 17:08 StraubCreative

@Abridbus @std-odoo When you have a moment can you review this change? We will be documenting the from_filter in as well: https://github.com/odoo/documentation/pull/2055

We are open to suggestions. Thanks, Tim

@StraubCreative Although this PR is for V15 only, this document is being updated in PR https://github.com/odoo/documentation/pull/2075 (V13-V15)

tiku-odoo avatar Aug 26 '22 13:08 tiku-odoo

Hi @tiku-odoo and @std-odoo!

Thanks for the suggestions! I made the content change and I updated the commit message tag to use all uppercase.

samueljlieber avatar Sep 07 '22 14:09 samueljlieber

Then, we can simply copy the content onto this PR.

while trying to keep the content of the email_servers.rst file from this PR as close to the email_servers.rst file from PR #2075.

If both PRs are editing the same content in the same file, then we will likely run into a merge conflict during rebase.

Normally, the merge conflict is solved by picking the the changes from w/e commit has the correct content, as in, there shouldn't be a need to manually make sure the versions match.

However, given that there are considerable differences between the two versions, either @samueljlieber or I would need guidance as to where the last PR ends and where the new one begins. It sounds like @mivu-odoo is asking for the same thing as to avoid reviewing content that would become obsolete with the forward-port from #2075 .

I agree to let #2075 get merged first-- afterwards, let's see if a merge conflict shows up. If it does, then let's jump on a a screenshare @samueljlieber @tiku-odoo and go through the merge conflict together so we can set this up right for @mivu-odoo 's review.

StraubCreative avatar Sep 16 '22 17:09 StraubCreative

Update:

We're just waiting for the forward-port PRs to finish up on #2075. Had to solve a merge conflict on one of them which affected a few others, but they should be on track again.

After those are done we can rebase those changes into this PR and @tiku-odoo / @std-odoo we'll need your help picking what changes we should keep for the final version of the file.

cc: @mivu-odoo @samueljlieber

StraubCreative avatar Sep 28 '22 17:09 StraubCreative

@StraubCreative / @samueljlieber --

It looks like all the forward ports for PR #2075 have been closed out.

The material in this PR should be placed before the section on 'Set up different dedicated servers for transactional and mass mails'.

For this change we will be adding Lines 217 --> 247 in the files changes doc on this PR:


Setting up different outgoing email servers for a multi-company environment

The "From Filter" allows for the use of a specific outgoing email server depending on the "From" email address that Odoo is sending on behalf of. When an email is sent from Odoo and the "From Filter" is configured, then the email server will be chosen as follows:

#. Odoo searches for an email server having the same "From Filter" as the "From" email address defined in the outgoing email. For example, if the "From" email address is [email protected], only the email servers having the "From Filter" equal to [email protected] will be returned.

#. If no email servers are found, then Odoo searches for an email server having the same domain in the "From Filter" as in the "From" email address of the outgoing email. For example, if the "From" email address is [email protected], only the email servers having the "From Filter" equal to example.com will be returned.

If no email servers are found after checking for the domain, then Odoo will return all email servers without any "From Filter" set.

Should this previous query return no results, then Odoo performs a search for an email server using the system parameter: 'mail.default.from'. First, the email address listed will attempt to match an email server and then the domain will attempt a match.

If no email server is found then Odoo will return the first outgoing email server (sorted by priority). In this case, it is likely the email configuration will be spoofing the email and it will be flagged as Spam.

.. note:: If several email servers are found, then Odoo will use the first one according to its priority. For example, if there are two email servers, one with a priority of 10 and the other with a priority of 20, then the email server with a priority of 10 will be used.

tiku-odoo avatar Oct 04 '22 20:10 tiku-odoo

Commit af46e00 to correct changes email_servers.rst.

In this PR #2627, changes were initially made to .../discuss/advanced/email_servers.rst when they should have been made to .../general/email_communication/email_servers.rst.

samueljlieber avatar Nov 01 '22 20:11 samueljlieber

@mivu-odoo This document has been updated with your changes. Can you review the doc once more? Thanks in advance for your help on this doc :)

tiku-odoo avatar Nov 03 '22 15:11 tiku-odoo

Hi @StraubCreative 👋 this doc is ready for a final technical review, thank you!

samueljlieber avatar Nov 04 '22 19:11 samueljlieber

@mivu-odoo When you have a moment can you review this doc again? Thanks in advance for your review. 👍

tiku-odoo avatar Nov 09 '22 16:11 tiku-odoo

@mivu-odoo This PR is ready for another review from you when you have a chance. Thanks in advance for your help on this From Filter PR.

tiku-odoo avatar Nov 10 '22 18:11 tiku-odoo

Thanks @mivu-odoo

@StraubCreative This doc is ready for your technical review whenever you have a moment. Thanks in advance for your help on this PR. 👍

tiku-odoo avatar Nov 10 '22 21:11 tiku-odoo

@samueljlieber @AntoineVDV this pull request has forward-port PRs awaiting action (not merged or closed): odoo/documentation#2990

  • odoo/documentation#2991
  • odoo/documentation#2992
  • odoo/documentation#2993

fw-bot avatar Nov 25 '22 05:11 fw-bot

@samueljlieber @AntoineVDV this pull request has forward-port PRs awaiting action (not merged or closed): odoo/documentation#2990

  • odoo/documentation#2991
  • odoo/documentation#2992
  • odoo/documentation#2993

fw-bot avatar Nov 26 '22 05:11 fw-bot

@samueljlieber @AntoineVDV this pull request has forward-port PRs awaiting action (not merged or closed): odoo/documentation#2990

  • odoo/documentation#2991
  • odoo/documentation#2992
  • odoo/documentation#2993

fw-bot avatar Nov 27 '22 05:11 fw-bot

@samueljlieber @AntoineVDV this pull request has forward-port PRs awaiting action (not merged or closed): odoo/documentation#2990

  • odoo/documentation#2991
  • odoo/documentation#2992
  • odoo/documentation#2993

fw-bot avatar Nov 28 '22 05:11 fw-bot

@samueljlieber @AntoineVDV this pull request has forward-port PRs awaiting action (not merged or closed): odoo/documentation#2990

  • odoo/documentation#2991
  • odoo/documentation#2992
  • odoo/documentation#2993

fw-bot avatar Nov 29 '22 05:11 fw-bot

@samueljlieber @AntoineVDV this pull request has forward-port PRs awaiting action (not merged or closed): odoo/documentation#2990

  • odoo/documentation#2991
  • odoo/documentation#2992
  • odoo/documentation#2993

fw-bot avatar Nov 30 '22 05:11 fw-bot