documentation
documentation copied to clipboard
odoo
[IMP] account, account_report, l10n_*: Introduce unified reporting en…
…gine
This commit adapts account's model to the new report engine introduced for v16, and updates the data files accordingly.
account.report model is now declared in community, together with the other models used by the reporting. This is done so that the tax tags can properly be created by the tax report and used on tax templates. All the actual computation logic stays in enterprise.
See enterprise commit for full details.
Task 2524389
Signed-off-by: Julien Alardot (jual) [email protected]
A next PR will need to be done to fix the links (and a few other things) @robodoo r+
@jcs-odoo @AntoineVDV Congratulations! You are the blocking point in THE merge for accounting.
@jcs-odoo @AntoineVDV He is trying to say: "Can you please recheck this PR. It should be ok now. Many thanks! :smile: "
@jcs-odoo @AntoineVDV Did not I put it like it is of a great honour to you?
Hello @jco-odoo and @smetl I'm not part of this review process, nor should I. I'm not competent in this matter (and there.... my great honor flies away :D )
Normally, the reviewers in the team account-dev-doc-review should have added odoo/doc-review as the next reviewer of this PR. Here, it would have been a re-request, since Antoine immediately reviewed this PR.
Now, if wan approved this pr on behalf of account-dev-doc, forgot to add odoo/doc-review as reviewer and didn't comment anything after robodoo replied that he didn't have r+ privilege at 5.30pm yesterday. Well... I think Antoine and I don't deserve your congratulations 😅
@jcs-odoo @AntoineVDV Congratulations! You are the blocking point in THE merge for accounting.
Hello @jco-odoo, do you really need to behave like an asshole here?
Let me remind you that the PR was opened 22 days ago, and I reviewed it only 21 minutes later. Since then, there have been 10 pushes to the PR and no hint whatsoever that it was ready for a new review. For your information, the job of a reviewer is not to track every single PR they are involved in and check if the last push seems to be the final one.
I honestly fail to see how I am a "blocking point" in this process, and if I actually am, what gives you the right to use that tone to talk to colleagues?
@AntoineVDV I was trying to mock with the lengths these processes can take even if everyone is trying their best to get things done. Nothing personal. I could have taken more care making that clear. Sorry.
@smetl @AntoineVDV linked pull request(s) odoo/enterprise#28648, odoo/odoo#94125, odoo/upgrade#3695 not ready. Linked PRs are not staged until all of them are ready.