Update google_spreadsheets.rst

[frin-odoo]

Some minor grammar changes proposed.

[robodoo]

Pull request status dashboard.

[frin-odoo]

hi,

I'm totally new to this process, therefore I have some questions

1. I find your suggestions great, do I do those changes, or will you?
2. after the changes are done and posted, what else do I have to do, or do you take it from there?

thanks.

On Fri, Apr 22, 2022 at 5:25 PM meng-odoo @.***> wrote:

@.**** requested changes on this pull request.

@frin-odoo https://github.com/frin-odoo Hello! Thanks for your contribution here. I think the grammar changes you made are great, and request that we go a step further while we're here on this doc and update the formatting of a couple things that need a change.

Please see my comments below and let me know if you have any questions :)

In content/applications/sales/crm/performance/google_spreadsheets.rst https://github.com/odoo/documentation/pull/1844#discussion_r856596318:

Authorization Code and Get Authorization Code are now available.

.. image:: google_spreadsheets/authori.png :align: center :alt: Enable the Google Drive and Google Spreadsheet features in Odoo

-Now, link your Google account with Odoo going to :menuselection:Get Authorization Code --> +Now, link your Google account with Odoo by going to :menuselection:Get Authorization Code -->

Hi! The grammar change is good here.

Let's also fix the menuselection piece since this is not an actual menu in Odoo. What's listed here is trying to showcase linear steps, so this can be done as a sentence or even a bulleted list to indicate instructions to follow. For example:

Now, link your Google account with Odoo by following these steps:

• Get Authorization Code
• Select your Google account
• Enter your password
• Copy the code
• Paste it into the Authorization Code field

---

In content/applications/sales/crm/performance/google_spreadsheets.rst https://github.com/odoo/documentation/pull/1844#discussion_r856680395:

@@ -48,7 +48,7 @@ Link a Spreadsheet with Odoo Applications ============

-You have 2 different formulas of using Google Spreadsheet in Odoo: retrieve data and retrieve +You have 2 different formulas available when using Google Spreadsheet in Odoo: retrieve data and retrieve

The grammar's good here too.

Let's also add italics around retrieve data and retrieve grouped sums to indicate that they are specific formulas and not just generic copy on the page.

In content/applications/sales/crm/performance/google_spreadsheets.rst https://github.com/odoo/documentation/pull/1844#discussion_r856680397:

@@ -48,7 +48,7 @@ Link a Spreadsheet with Odoo Applications ============

-You have 2 different formulas of using Google Spreadsheet in Odoo: retrieve data and retrieve +You have 2 different formulas available when using Google Spreadsheet in Odoo: retrieve data and retrieve

The grammar's good here too.

Let's also add italics around retrieve data and retrieve grouped sums to indicate that they are specific formulas and not just generic copy on the page.

— Reply to this email directly, view it on GitHub https://github.com/odoo/documentation/pull/1844#pullrequestreview-950615499, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYJMKWETPNRKIYT5CMI6G6TVGM7NXANCNFSM5T723RDQ . You are receiving this because you were mentioned.Message ID: @.***>

--

Francisco Infante

BSA - Odoo Inc.

250 Executive Park Blvd Suite #3400

San Francisco, CA 94134

[meng-odoo]

@frin-odoo Hi! Thanks for your questions. I'm new to this process too, but I'll try my best to answer.

1. Can you please make those changes to the RST file?
2. After the changes have been made, I will move this pull request to the next stage in the review process by tagging the technical reviewer. He may come back and ask us to make more changes. Once he approves, he will merge the PR into the published documentation.

Hopefully that makes sense! Please let me know if you have any more questions. Thanks.

[jcs-odoo]

Hi @meng-odoo !

Let's do the changes ourselves when the contribution comes from external users or from non-dev colleagues. Seeing patch in the branch name like above is often a good indicator that someone clicked on "edit on GitHub" directly from the documentation. This makes me also realize that the target 15.0 is wrong and should be 13.0... I update this now.

[jcs-odoo]

@robodoo r+