documentation icon indicating copy to clipboard operation
documentation copied to clipboard

[FIX] inventory: fix typo

Open Whenrow opened this issue 3 years ago • 6 comments

Whenrow avatar Apr 21 '22 14:04 Whenrow

Moved this one forward for the small edit.

jirocha avatar Apr 21 '22 19:04 jirocha

Hello @Whenrow and @jues-odoo :)

I would suggest targeting 13.0 since the page is exactly the same. If a change can be applied to multiple versions, we target the oldest one so that fw-bot can create the forward-port pull requests :)

Here, I'm afraid you can't simply rebase and change the target on the PR --> all code-owners would be pinged. It's not a biggie, but the best way is to close this PR, cherry-pick your commit on a 13.0 branch and create a new PR targeting 13.0.

Also, speaking of code-owners, the appropriate reviewers are tagged automatically. No need to request a review from odoo/content-doc or AntoineVDV manually at the creation of the PR. HOWEVER, once the reviewer has approved the PR, then, the reviewer can request a review manually from the group odoo/content-doc to merge the PR :)

I hope this helps.

Cheers!

jcs-odoo avatar Apr 21 '22 21:04 jcs-odoo

Here, I'm afraid you can't simply rebase and change the target on the PR --> all code-owners would be pinged.

I believe you can avoid this by putting the PR back to draft (top right) before retargeting. Also, please don't forget to update the .pot in the locale/ directory.

mart-e avatar Apr 22 '22 05:04 mart-e

Here, I'm afraid you can't simply rebase and change the target on the PR --> all code-owners would be pinged.

I believe you can avoid this by putting the PR back to draft (top right) before retargeting. Also, please don't forget to update the .pot in the locale/ directory.

Ooooh that's clever :) Thanks @mart-e cc @AntoineVDV

jcs-odoo avatar Apr 22 '22 08:04 jcs-odoo

I believe that requesting a review from @content-doc which is the parent team of all content teams pings everyone in that team. Please don't do that. Instead, let C3POdoo assign the correct codeowner (content) team when the PR is created. Then, that team can request a review from @doc-review when they're satisfied with the content changes.

cc @StraubCreative

AntoineVDV avatar Apr 22 '22 10:04 AntoineVDV

@robodoo r+

jcs-odoo avatar Aug 31 '22 10:08 jcs-odoo

Here, I'm afraid you can't simply rebase and change the target on the PR --> all code-owners would be pinged.

I believe you can avoid this by putting the PR back to draft (top right) before retargeting. Also, please don't forget to update the .pot in the locale/ directory.

Hi @mart-e ! I am not sure what you mean by updating the .pot files. I just had a look at it, but I don't understand what's its use nor what we should do with it. Do you mean all doc PR should normally edit these files?

jcs-odoo avatar Aug 31 '22 10:08 jcs-odoo

@Whenrow @jcs-odoo staging failed: ci/runbot on 563743c2eb889056d2122b0dad74f3b1609883ef (view more at https://runbot.odoo.com/runbot/build/18889647)

robodoo avatar Aug 31 '22 10:08 robodoo

@robodoo retry

AntoineVDV avatar Aug 31 '22 11:08 AntoineVDV