documentation icon indicating copy to clipboard operation
documentation copied to clipboard
verified publisher icon odoo

[IMP] Documents: email alias

Open Donapi opened this issue 1 year ago • 1 comments

taskid-3898917 only applicable to 17.2

Donapi avatar Jul 01 '24 14:07 Donapi

Pull request status dashboard

robodoo avatar Jul 01 '24 14:07 robodoo

Hi @Donapi as I mentioned in a reply to one of my comments, I think there's a missing paragraph compared to the first version of this PR, could you please check? I also added another comment on lines 253-257.

@auva-odoo Sorry that I missed your comment! It should be fine now :)

Donapi avatar Jul 16 '24 14:07 Donapi

Hi @Donapi as I mentioned in a reply to one of my comments, I think there's a missing paragraph compared to the first version of this PR, could you please check? I also added another comment on lines 253-257.

@auva-odoo Sorry that I missed your comment! It should be fine now :)

You didn't miss it, I saw it yesterday :wink: I think it went missing went you force-pushed your changes after my first review. I see the paragraph now (on lines 227-230; for some reason it now makes it look like this isn't something you changed in this PR although it was), but without the changes that I suggested, could you please check my original comment again?

auva-odoo avatar Jul 17 '24 06:07 auva-odoo