docker icon indicating copy to clipboard operation
docker copied to clipboard

use wkhtmltopdf from os supplied base apt source

Open sanderkwantes opened this issue 3 years ago • 3 comments

This fix ensures that odoo does not depend on an amd64 image. Apple Silicon M1 developers in particular are going to be happy about this. Docker containers are now created from an arm64 image for Apple Silicon Docker for Mac users. This eliminates the use of the more inefficient 'platform: linux/amd64' workaround.

sanderkwantes avatar Nov 22 '21 23:11 sanderkwantes

The default included version of wkhtmltopdf in debian buster is in line with Odoo's recommended version: https://packages.debian.org/buster/wkhtmltopdf

sanderkwantes avatar Nov 22 '21 23:11 sanderkwantes

+1 from my side for the arm64 image. However, obviously, the images are built and pushed manually to the docker hub?

Maybe we consider using Github Actions here for automatic build and push?

floflock avatar Nov 27 '21 08:11 floflock

See here @em230418 @floflock https://github.com/odoo/docker/issues/376#issuecomment-1046174407

gustavovalverde avatar Feb 20 '22 06:02 gustavovalverde

I'm sorry to say that it will not work. The only supported wkhtmltopdf version is 0.12.5-1.

d-fence avatar Feb 16 '23 12:02 d-fence

@d-fence it works same. We use 0.12.6 for 2 years now.

leimantas avatar Feb 16 '23 12:02 leimantas