docker
docker copied to clipboard
what is the design idea behind hardcoding dbname='postgres' and choosing this name.
If you have coded this[1], why the hell are you not adding the database name? I am so curious what made you do this. Because it is really a weird design decision. And if you hardcode a dbname, why 'postgres'??? Why not eg odoo/crm/erp or so? Choosing the name postgres is sort of the worst name you can pick.
[1] arg_parser.add_argument('--db_host', required=True) arg_parser.add_argument('--db_port', required=True) arg_parser.add_argument('--db_user', required=True) arg_parser.add_argument('--db_password', required=True) arg_parser.add_argument('--timeout', type=int, default=5)
Lol —- please. stop. opening. issues. The docker repo is an inappropriate place to post these type of issues. You need to go to the main repo where Odoo is built and pray a dev will spend their time on these senseless questions.
@f1-outsourcing I found https://github.com/odoo/odoo/pull/12885 which might help you.
If it does feel free to close this issue in an effort to clean up issues.
Yes, keep also in mind if you are working on docker images, that if the container is started it does not require to download or so. I have some running in an air gapped environment / private lan (ideal for such crm stuff) super annoying if then some rookie created it like this.
@f1-outsourcing thanks for the update. In an effort to clean up the issue queue can you close this issue?
Oh yes sure, I thought you would close it.