Max Odnoletkov
Max Odnoletkov
@tpope any other fixes here or is it good to go?
As described above, having just paths and line numbers for both sides is not enough to unambiguously define position in a diff for all providers. We also need the side...
What about the internal use case in `s:cfile()`? It could look something like: ```diff diff --git a/autoload/fugitive.vim b/autoload/fugitive.vim index 551baa7..21a2fd2 100644 --- a/autoload/fugitive.vim +++ b/autoload/fugitive.vim @@ -5705,19 +5705,15 @@ function!...
Yes this is sufficient, updated both PRs. One remaining issue I see is when the range spans multiple files in the diff – we don't detect file name for the...
> To be clear, we don't actually want to do anything with that second filename, correct? We just want to avoid pretending that second file's line number belongs to the...
FWIW the workaround I use for this is navigating through some related commit. It is easy to grab hash for some commit touching the file on Github – i.e. last...
The same problem exists for submodules currently
Scrolling. So that as much of the conflict is visible as possible. I always need to see the full conflict before I can do anything with it.
I find myself mostly using `[f`/`]f` to quickly browse/review files in a single directory. So for me the most annoying thing is that it actually moves through the whole tree...