tool-suite-X
tool-suite-X copied to clipboard
odk-x
Redesign Survey and Table Top Appbar to meet ODK-X Design Guidelines
1. Clone all 4 repositories locally into Android Studio ( Tables, Survey, Services and Android Library ) into the same folder, check readme https://github.com/odk-x/survey and make sure they're running without any errors
Survey Top Appbar currently looks like this:
As you can see, It currently doesn't conform to ODK-X Design Guidelines
2. Make changes to the Top Appbar so it conform to ODK-X Design Guidelines,
3. Send a Pull Request to Survey repository ( Development Branch ) with the changes and also a screenshot
###Read the docs well so you know where to make required changes
Yes, please go ahead to work on it @Chinex-Boroja
Alright. Thank you, I will update you on the progress
@Redeem-Grimm-Satoshi @wbrunette, I have set up my environment and cloned all four repositories. I am checking out the apps
Hi @Cveman1 @Redeem-Grimm-Satoshi, currently on this issue and I have a few things I am confused about while inspecting the code base.
- In the
resfolder 📁, checking thevaluessub-folder, I can't seem to locate thestyles.xmlwhere I can change the Top Appbar theme, also the same thing goes for thecolors.xmlfile. I am a bit confused as to where to locate it, or am I to create them in the values folder? - Secondly, this is how the Survey Top Appbar looks after running it on my android device, the blue app bar colour is not showing, which is a bit different from the screenshot sent
Hi @Cveman1 @Redeem-Grimm-Satoshi, currently on this issue and I have a few things I am confused about while inspecting the code base.
* In the `res` folder 📁, checking the `values` sub-folder, I can't seem to locate the `styles.xml` where I can change the Top Appbar theme, also the same thing goes for the `colors.xml` file. I am a bit confused as to where to locate it, or am I to create them in the values folder? * Secondly, this is how the Survey Top Appbar looks after running it on my android device, the blue app bar colour is not showing, which is a bit different from the screenshot sent 
-
Great question, the app theming resides in the android library ( read more here ) Android Library Repo
-
Yeah, Mine was altered don't worry about that
Hi @Redeem-Grimm-Satoshi @Cveman1 and @wbrunette , I am stuck on the Top Appbar color not reflecting. I have added the color values in the color.xml file, as described in the ODK-X Design. And also used them in the theme.xml file. But when running the app, the Appbar is not changing or showing the color changes. The color for the status bar is showing. This is the image screenshot
But in Android Studio, I can see the colors properly reflected in the sort.xml file in the menu folder. This is also a screenshot to provide a bit more context
I have also checked the Manifest file in the survey folder to investigate the app-theme. Probably I am missing something
Great, try to understand how appbars work : https://m2.material.io/components/app-bars-top/android#regular-top-app-bar
Great, try to understand how appbars work : https://m2.material.io/components/app-bars-top/android#regular-top-app-bar
Thank you. I still have some question @Redeem-Grimm-Satoshi
I figured out how to change the topbar app colour from theme.xml in the androidlibrary module. This is the update so far with a screenshot
- So is this what I am expected to do? Based on my understanding of the question.
- Secondly, it seems I am not touching any file on the
survey_app, and I just want to find out if I am doing it the right way
I will appreciate a feedback, thank you
@Chinex-Boroja You did great
Thank you @Redeem-Grimm-Satoshi, what should be my next step from here? Raising a Pull Request?
Great, try to understand how appbars work : https://m2.material.io/components/app-bars-top/android#regular-top-app-bar
Thank you. I still have some question @Redeem-Grimm-Satoshi I figured out how to change the topbar app colour from
theme.xmlin theandroidlibrary module. This is the update so far with a screenshot
- So is this what I am expected to do? Based on my understanding of the question.
- Secondly, it seems I am not touching any file on the
survey_app, and I just want to find out if I am doing it the right wayI will appreciate a feedback, thank you
Hi @Redeem-Grimm-Satoshi I am still expecting a response to the second question because it seems I did not touch any file from the survey_app. I only made changes to the colors.xml and theme.xml in the androidLibrary. So not sure on how to go about raising the pull request
Great, try to understand how appbars work : https://m2.material.io/components/app-bars-top/android#regular-top-app-bar
Thank you. I still have some question @Redeem-Grimm-Satoshi I figured out how to change the topbar app colour from
theme.xmlin theandroidlibrary module. This is the update so far with a screenshot
- So is this what I am expected to do? Based on my understanding of the question.
- Secondly, it seems I am not touching any file on the
survey_app, and I just want to find out if I am doing it the right wayI will appreciate a feedback, thank you
Hi @Redeem-Grimm-Satoshi I am still expecting a response to the second question because it seems I did not touch any file from the
survey_app. I only made changes to thecolors.xmlandtheme.xmlin theandroidLibrary. So not sure on how to go about raising the pull request
Yes you didn't because Android Library is where other ODK-X apps pull their resources from ( eg theming, etc.. )...
A PR can be sent to the Android Library Repo