tool-suite-X icon indicating copy to clipboard operation
tool-suite-X copied to clipboard

ODK-X Services - Set the status bar color

Open maprehensive opened this issue 2 years ago • 39 comments

Set the color of the app status bar to match the app background color in ODK-X Services.

Screen Shot 2022-10-02 at 09 40 09 Example of the default status bar color (left) and status bar color changed to match the app background (right)

Why this needs to be improved:

  • the menu bar in the application looks crowded by the default grey status bar

Guidance for this issue:

  • Change settings in styles.xml or theme.xml
  • Light mode: <item name="android:navigationBarColor" tools:targetApi="21">@color/white</item>
  • For dark mode see design guidelines below

Guidelines:

This issue is referenced on slide 12 of the ODK-X Design Guidelines

Outreachy

This issue can be used for an Outreachy application for the project Custom UI components for ODK-X mobile apps This issue is for the Technical stream of the project.

Please request to be assigned to the issue so we can track the number of peopling doing this exercise. Multiple people can work on this issue simultaneously.

You do not need to be assigned to this issue to work on it for an Outreachy application

maprehensive avatar Oct 02 '22 01:10 maprehensive

@maprehensive can I work on this task?

Redeem-Grimm-Satoshi avatar Oct 08 '22 16:10 Redeem-Grimm-Satoshi

@maprehensive I would love to work on this task. May I please get permission to work on it?

phelisa1 avatar Oct 08 '22 23:10 phelisa1

I would love to work on this project if i will be granted access to the task, thank you

kryptosjay avatar Oct 08 '22 23:10 kryptosjay

@Redeem-Grimm-Satoshi since I've assigned you to https://github.com/odk-x/tool-suite-X/issues/365 I will assign this to the next requester.

@phelisa1 Thanks! You are assigned to this issue.

maprehensive avatar Oct 09 '22 01:10 maprehensive

@kryptosjay I've assigned you to this issue. Thanks!

maprehensive avatar Oct 09 '22 01:10 maprehensive

Hello @maprehensive I would love to work on this issue

Augusta2 avatar Oct 09 '22 16:10 Augusta2

Hi @maprehensive, I would like to collaborate with other assigned contributors to work on this task.

Hilzygift avatar Oct 10 '22 22:10 Hilzygift

Hi @maprehensive I would like to work on this issue. Thanks

ghost avatar Oct 11 '22 11:10 ghost

Hello @maprehensive , I would love to work on this issue.

Joyfro avatar Oct 11 '22 17:10 Joyfro

  • @maprehensive this ** navigationBarColor** doesn't work

So I did some changes.

  1. I used statusBarColor instead of naviagationBarColor ( Tested Locally and it worked )
  2. Added windowsLightStatusBar ( with boolean value: [true] so that status bar doesn't become opaque
  3. Light and Dark theme colors implemented

Please Check PR for this latest modifications.

Redeem-Grimm-Satoshi avatar Oct 11 '22 20:10 Redeem-Grimm-Satoshi

Hello@maprehensive, I would love to work on this issue, and I will be glad if the opportunity is given to me. Thank you.

Blessing1135 avatar Oct 11 '22 22:10 Blessing1135

Hi , I want to work on this issue, and would be thankful for the opportunity

NiranjanNlc avatar Oct 13 '22 03:10 NiranjanNlc

Hello @maprehensive, can you please guide me on how I can work on this issue?. I have forked and cloned the services repository but I can't seem to find any settings, theme.xml , or styles.xml files

Joyfro avatar Oct 13 '22 11:10 Joyfro

Helo @maprehensive thank you for the opportunity pls I need a.guide on how to go about it

Blessing1135 avatar Oct 13 '22 14:10 Blessing1135

@NiranjanNlc @Joyfro @Blessing1135 you can work ion this without being assigned.

To get started, check page 12 of the style guide, there are some notes there on the relevant files.

maprehensive avatar Oct 13 '22 15:10 maprehensive

Hello @maprehensive can I work on this? I need like a guide on how to go about this

Coder-For-Life avatar Oct 13 '22 19:10 Coder-For-Life

Hello @maprehensive could you pleasee assign me to this project too? I am excited to jump on it

JessicaItepu avatar Oct 13 '22 20:10 JessicaItepu

@maprehensive I have resolved this issue and created a pull request. https://github.com/odk-x/services/pull/250 Also tested on my android emulator and it worked. please see screenshots below:

android studio

Joyfro avatar Oct 14 '22 15:10 Joyfro

@NiranjanNlc @Joyfro @Blessing1135 you can work ion this without being assigned.

To get started, check page 12 of the style guide, there are some notes there on the relevant files.

Hey @maprehensive , I have resolved the issuse and created a pull request to address it . Please review it . I have verified both the light mode and dark mode in my device . Please refer the screenshot below .

NiranjanNlc avatar Oct 15 '22 09:10 NiranjanNlc

@maprehensive I'm confused, are we supposed to use a specific language or any language of our choice?

Coder-For-Life avatar Oct 15 '22 20:10 Coder-For-Life

@maprehensive I'm confused, are we supposed to use a specific language or any language of our choice?

@Coder-For-Life you can make the required changes in Android Studio in the theme files. There was some instruction in a link in the issue description, and some notes from other contributors.

See if reading back through those comments and reviewing other contributions helps.

maprehensive avatar Oct 16 '22 10:10 maprehensive

Hello @maprehensive could you pleasee assign me to this project too? I am excited to jump on it

No need to be assigned - you can go ahead and work on it!

maprehensive avatar Oct 16 '22 10:10 maprehensive

@maprehensive Trust you are good? Thank you so much for the opportunity, however I have a question regarding the issue, must this changes be made using the android Studio or one can use figma? I am very new to these and I need help. Thank you.

Blessing1135 avatar Oct 17 '22 12:10 Blessing1135

Hi @Blessing1135, some issues have descriptions that tell whether it is technical or for the UI stream of the applicants. Although I stand to be corrected, the technical stream is for the Android developers while the design is for the UI designers:

See here: image

Cveman1 avatar Oct 17 '22 17:10 Cveman1

@Blessing1135 the changes for this issue would need to be made using Android Studio.

Thanks @Cveman1 !

maprehensive avatar Oct 18 '22 13:10 maprehensive

@maprehensive Hello Dear, I see that more of one worked on this task, Is it okay? Can I work on what I issue want without worry if another one get worked on it before me ?

Rubadel avatar Oct 19 '22 08:10 Rubadel