tool-suite-X
tool-suite-X copied to clipboard
odk-x
ODK-X Tables - set the status bar color
Set the color of the app status bar to match the app background color in ODK-X Tables.
Example of the default status bar color (left) and status bar color changed to match the app background (right)
Why this needs to be improved:
- the menu bar in the application looks crowded by the default grey status bar
Guidance for this issue:
- Change settings in styles.xml or theme.xml
- Light mode:
<item name="android:navigationBarColor" tools:targetApi="21">@color/white</item> - For dark mode see design guidelines below
Guidelines:
This issue is referenced on slide 12 of the ODK-X Design Guidelines
Outreachy
This issue can be used for an Outreachy application for the project Custom UI components for ODK-X mobile apps This issue is for the Technical stream of the project.
Please request to be assigned to the issue so we can track the number of peopling doing this exercise. Multiple people can work on this issue simultaneously.
You do not need to be assigned to this issue to work on it for an Outreachy application
@Redeem-Grimm-Satoshi since I've assigned you to https://github.com/odk-x/tool-suite-X/issues/365 I will assign this to the next requester.
@salmasabo Thanks! You are assigned to this issue.
Good day @maprehensive, I am from Outreachy and this is my first time working with GitHub. I can't seem to find the file I need to work on. Can you point me in the right direction? Thank you
@Augusta2 , the changes you need to make is in the android Library Project https://github.com/odk-x/androidlibrary
you can read the guide on setting up tables project https://github.com/odk-x/tables/#setting-up-your-environment @maprehensive , i can also join @Augusta2 to work on the issue and implementing the app bar dark mode .
Hello, i would love to work on this project. Could you please assign it to me.
Hi, I would love to work on this issue. could you please assign it to me? @maprehensive
@Redeem-Grimm-Satoshi since I've assigned you to https://github.com/odk-x/tool-suite-X/issues/365 I will assign this to the next requester.
@salmasabo Thanks! You are assigned to this issue.
Thank you.! I have began work on it already.
@NiranjanNlc Thanks! You can work on this issue without being assigned.
@maprehensive , i have created a PR to address the issue
https://github.com/odk-x/androidlibrary/pull/235
@NiranjanNlc Thanks! You can work on this issue without being assigned.
Hey @maprehensive , I have created a pull request to address the issuse . I have verified for both light and dark mode on my device .
@maprehensive thia is my submission on the given project
Thanks @JessicaItepu - nicely laid out! Have you submitted a pull request with the changes?
@NiranjanNlc Thanks! You can work on this issue without being assigned.
Hey @maprehensive , I have created a pull request to address the issuse . I have verified for both light and dark mode on my device .
I love the way this looks @NiranjanNlc
Hello. @salmasabo, for your image to show i think you have to put it first. That is select image first .. then add your comment.
Hello. @salmasabo, for your image to show i think you have to put it first. That is select image first .. then add your comment.
Hi Jessica,thank you for letting me know,let me correct it now.
@Jessica I've replied you on ODK-X forum
On Wed, Oct 19, 2022, 7:33 PM JessicaItepu @.***> wrote:
Hello i need your help. How can i contact you outside this forum. @salmasabo https://github.com/salmasabo
— Reply to this email directly, view it on GitHub https://github.com/odk-x/tool-suite-X/issues/364#issuecomment-1284417200, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKZUZEQUAMWEE6L25IL5UOLWEA5FZANCNFSM6AAAAAAQ2V6DTY . You are receiving this because you were mentioned.Message ID: @.***>
Redeem Grimm here
On Wed, Oct 19, 2022, 8:57 PM Ram Automi @.***> wrote:
@Jessica I've replied you on ODK-X forum
On Wed, Oct 19, 2022, 7:33 PM JessicaItepu @.***> wrote:
Hello i need your help. How can i contact you outside this forum. @salmasabo https://github.com/salmasabo
— Reply to this email directly, view it on GitHub https://github.com/odk-x/tool-suite-X/issues/364#issuecomment-1284417200, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKZUZEQUAMWEE6L25IL5UOLWEA5FZANCNFSM6AAAAAAQ2V6DTY . You are receiving this because you were mentioned.Message ID: @.***>
Hello i need your help. How can i contact you outside this forum. @salmasabo
Okay,Hit me up on slack
Redeem Grimm here … On Wed, Oct 19, 2022, 8:57 PM Ram Automi @.> wrote: @jessica I've replied you on ODK-X forum On Wed, Oct 19, 2022, 7:33 PM JessicaItepu @.> wrote: > Hello i need your help. How can i contact you outside this forum. > @salmasabo https://github.com/salmasabo > > — > Reply to this email directly, view it on GitHub > <#364 (comment)>, > or unsubscribe > https://github.com/notifications/unsubscribe-auth/AKZUZEQUAMWEE6L25IL5UOLWEA5FZANCNFSM6AAAAAAQ2V6DTY > . > You are receiving this because you were mentioned.Message ID: > @.***> >
Ohhhhh. I am so sorry. Just got the mail.
@maprehensive i have created a PR to address the issue
- https://github.com/odk-x/tables/pull/204 (Pull request on Tables)
- https://github.com/odk-x/androidlibrary/pull/235 (Pull request on Android Library)
@maprehensive here's my submission to the issue.
Hello @maprehensive, my previous submission to this issue was a designed one as at the time i didn't know the issue was technical.
Noe i have created a Pull request adressing it technically. This pull request covers the changes in all the ODK apps and their screenshots. Thank you