tool-suite-X icon indicating copy to clipboard operation
tool-suite-X copied to clipboard

Published 20 hours ago • verified publisher icon odk-x

Inherit locale for new instances created through linked_table

Open linl33 opened this issue 3 years ago • 14 comments

When a new instance is created through linked_table the new instance uses the default locale. If the parent instance uses a non-default locale, the child instance should inherit the locale used in the parent form.

This could be implemented by passing _locale to the new instance (if one isn't provided in newInstanceKeyToValueMap) at the line linked below https://github.com/odk-x/app-designer/blob/7abf14b16d940850cedfa66e2f9c2afd79553b3e/app/system/survey/js/prompts.js#L1035-L1038

linl33 avatar Mar 03 '21 08:03 linl33

Hi @linl33, I want to work on this issue, can you share some more detail?

kdsanskar07 avatar Mar 10 '21 10:03 kdsanskar07

Hi @kdsanskar07! For general getting started information, see https://forum.odk-x.org/t/welcome-gsoc-applicants/1195. If you have a specific question let me know.

linl33 avatar Mar 11 '21 03:03 linl33

@kdsanskar07 Could you give us an update on this issue? Let us know if you have any questions.

linl33 avatar Mar 30 '21 06:03 linl33

@linl33 @wbrunette can I work on this?

starboi02 avatar Apr 08 '21 21:04 starboi02

@starboi02 I am assigning this issue to you, but you have now reached a limit. Please complete the other issues or tell us which ones you are not going to work on.

wbrunette avatar Apr 08 '21 21:04 wbrunette

@wbrunette I am stuck at #228 for days, I tried every possible way but was unable to recreate the issue, hence becoming very difficult for me to sort it out and fix it. Apart from it I have made a PR for #209 and a PR for #190. I am very much willing to work on this issue.

starboi02 avatar Apr 08 '21 21:04 starboi02

@starboi02 it's assigned.

wbrunette avatar Apr 08 '21 21:04 wbrunette

@starboi02 it's assigned.

Thanks @wbrunette :)

starboi02 avatar Apr 08 '21 21:04 starboi02

@starboi02 can you give us an update on this issue? Do you have any questions?

wbrunette avatar Apr 15 '21 18:04 wbrunette

@wbrunette I am unable to resolve what newInstanceKeyToValueMap is. Can you please give some insight on it.

starboi02 avatar Apr 16 '21 10:04 starboi02

@starboi02 It's a typo, I meant to write newInstanceElementKeyToValueMap. This variable contains the evaluated value for newRowInitialElementKeyToValueMap. See https://docs.odk-x.org/xlsx-converter-reference/?highlight=newrowinitialelementkeytovaluemap#queries for more on newRowInitialElementKeyToValueMap

linl33 avatar Apr 16 '21 14:04 linl33

Hello @linl33, can I please work on this? What do I need to get started? Thanks

greatestofal avatar Oct 14 '21 11:10 greatestofal

Hi @greatestofal I have assigned this to you! Please see the previous comments in this thread for details on how to get started and let us know questions!

elmps2018 avatar Oct 14 '21 23:10 elmps2018

@wbrunette @elmps2018 @linl33 can you please assign this issue. I have a PR for this issue along side this too. Am just waiting for soomeone to assign then I push PRs

Ndacyayisenga-droid avatar Feb 12 '23 23:02 Ndacyayisenga-droid