tables add UI test for select tag in webview

Fixes #209 Added UI test for select tag in webview

Apr 08 '21 07:04 starboi02

Can one of the admins verify this patch? Also need an authorization to run tests.

Apr 08 '21 07:04 odk-x-bot

@linl33 can you please review this PR

Apr 08 '21 07:04 starboi02

runtests

Apr 09 '21 09:04 linl33

Please make sure the PR compile against the build variant snapshotUiTestDebug.

@wbrunette can you please guide me on how to do it.

Apr 12 '21 20:04 starboi02

Check out this PR https://github.com/odk-x/docs/pull/77 that is in-progress to improve the instructions on how to change the build variant.

Apr 12 '21 20:04 wbrunette

@wbrunette thanks, It cleared my doubt.

Apr 12 '21 21:04 starboi02

@wbrunette please review it I have made the requested changes

Apr 12 '21 21:04 starboi02

Have you run it to verify you test does what you think it does? To run the UI tests you must have a development version (compiled by you and installed on the device or emulator) of Services and Survey. Then you need to do a "grunt adbpush" of app-designer to setup everything correctly. Also you need OI File manager installed.

Apr 12 '21 21:04 wbrunette

@starboi02 Your changes should also include an HTML component to test select, or navigate to an existing page that contains select. Please make sure your test crashes Tables when compiled with an androidcommon version prior to https://github.com/odk-x/androidcommon/commit/4016020394e015c1c3182f2841a694c9b1b81091

Apr 13 '21 03:04 linl33

@starboi02 Your changes should also include an HTML component to test select, or navigate to an existing page that contains select. Please make sure your test crashes Tables when compiled with an androidcommon version prior to odk-x/androidcommon@4016020

Ok @linl33 I will add that and component and recreate the crash with androidcommon version specified by you.

Apr 13 '21 13:04 starboi02

Have you run it to verify you test does what you think it does? To run the UI tests you must have a development version (compiled by you and installed on the device or emulator) of Services and Survey. Then you need to do a "grunt adbpush" of app-designer to setup everything correctly. Also you need OI File manager installed.

Ok @wbrunette I will run it with the correct androidcommon version.

Apr 13 '21 13:04 starboi02

@starboi02 any update on this PR?

Apr 28 '21 20:04 wbrunette

@wbrunette sorry for the delay I got infected with covid-19 so could not contribute for a time period. I will try to complete it in a day or two.

Apr 29 '21 06:04 starboi02

@starboi02 no worries. I am was simply going through all the PRs to make sure that PRs were not waiting on review. Hope you recovery from COVID-19 is going well. No need to rush, you can take your time.

Apr 29 '21 11:04 wbrunette