odk-x
Create new instance btn and go to next prompt
The design outlined below addresses the navigation (Create new instance button and the go to next prompt button) issues in the ODK-Survey form .
The colors, font size, type, and spacing used adhere to the ODK-X Design guidelines
Any feedback or additional information would be greatly appreciated. Thank you.
On the first grid, image one compares the old instance button to the new one.
On the second grid, image one compares the go to next prompt button to the new one
@juayuohcarineneng19 Great work!
-
Can you provide a better screenshot like before and after the changes were made? side by side comparison would be better. It'll make it easier to review your PR by letting us know what was there before and what wasn't there without having to run the app
-
This PR title "Create new instance btn" seems vague, you did modifications not only on the Create new instance btn. It's important
*Code will be reviewed after this minor changes
@juayuohcarineneng19 I noticed you are adding grunt-shell to our environment is there a reason for that? why was it necessary? we try to minimize the number of packages needed for app-designer since users often have limited connectivity. Is there something that that grunt-cli could not do that you needed? @r0ssing
@juayuohcarineneng19 I noticed you are adding grunt-shell to our environment is there a reason for that? why was it necessary? we try to minimize the number of packages needed for app-designer since users often have limited connectivity. Is there something that that grunt-cli could not do that you needed? @r0ssing
Please I did not notice I was adding the grunt-shell to our environment. I will remove this. Thank You
@juayuohcarineneng19 Sorry for the delay reviewing.
Button is in line with the style guide, and it looks good. I'm ok with the changes.
@Redeem-Grimm-Satoshi I have reviewed design - can you review code and merge if ok?
@Redeem-Grimm-Satoshi I have reviewed design - can you review code and merge if ok?
@maprehensive Yes sure
@Chinex-Boroja Please check this out for any testing related issues @r0ssing This issue is ready to be merged :)
I just noticed this branch have some conflicts, @juayuohcarineneng19 try resolving them first
Conflicts resolved @Redeem-Grimm-Satoshi
@Chinex-Boroja Please check this out for any testing related issues @r0ssing This issue is ready to be merged :)
Hi @Redeem-Grimm-Satoshi, I am not really sure what I am meant to do here or how to go about this regarding writing tests, if that is what you mean. If you could explain, it will be quite helpful. Thank you
@Chinex-Boroja Please check this out for any testing related issues
@r0ssing This issue is ready to be merged :)
Hi @Redeem-Grimm-Satoshi , please it was mentioned in our meeting that @Chinex-Boroja can only write test for tables app and not app designer as he isn't familiar with app designer .