nginx-java-parser icon indicating copy to clipboard operation
nginx-java-parser copied to clipboard

Create valid OSGi bundle manifest

Open CodingFabian opened this issue 8 years ago • 6 comments

This changes the generated manifest to be OSGi compliant. declaring all imported and exported packages. No other changes in any of the compiled classes

Manifest-Version: 1.0
Bnd-LastModified: 1460299170325
Build-Jdk: 1.8.0_71
Built-By: fabian
Bundle-Description: Parses Nginx configuration files with JavaCC grammar
  based parser
Bundle-License: http://www.apache.org/licenses/LICENSE-2.0
Bundle-ManifestVersion: 2
Bundle-Name: com.github.odiszapc:nginxparser
Bundle-SymbolicName: com.github.odiszapc.nginxparser
Bundle-Version: 0.9.6
Created-By: Apache Maven Bundle Plugin
Export-Package: com.github.odiszapc.nginxparser.antlr;version="0.9.6";us
 es:="com.github.odiszapc.nginxparser,org.antlr.v4.runtime,org.antlr.v4.
 runtime.atn,org.antlr.v4.runtime.dfa,org.antlr.v4.runtime.tree",com.git
 hub.odiszapc.nginxparser.javacc;version="0.9.6";uses:="com.github.odisz
 apc.nginxparser",com.github.odiszapc.nginxparser;version="0.9.6";uses:=
 "com.github.odiszapc.nginxparser.javacc"
Import-Package: org.antlr.v4.runtime;version="[4.5,5)",org.antlr.v4.runt
 ime.atn;version="[4.5,5)",org.antlr.v4.runtime.dfa;version="[4.5,5)",or
 g.antlr.v4.runtime.tree;version="[4.5,5)"
Require-Capability: osgi.ee;filter:="(&(osgi.ee=JavaSE)(version=1.6))"
Tool: Bnd-2.4.1.201501161923

CodingFabian avatar Apr 10 '16 14:04 CodingFabian

Ok, it's up to you, senior OSGi engineer ;) Make all needed there.

odiszapc avatar Apr 10 '16 14:04 odiszapc

@CodingFabian Is it possible then to use the library as usual (maven dependency) ?

odiszapc avatar Apr 10 '16 14:04 odiszapc

yes, it does not change a thing. it is still a normal jar file as before, the only difference is that the plugin will generate the above manifest.mf automatically. one could do that by hand, be the generated ones are much better, especially when stuff changes they are updated automatically.

CodingFabian avatar Apr 10 '16 15:04 CodingFabian

Does the mvn package build the manifest automatically?

odiszapc avatar Apr 11 '16 00:04 odiszapc

yes

CodingFabian avatar Apr 11 '16 08:04 CodingFabian

@odiszapc what is your concern merging this?

CodingFabian avatar May 18 '16 08:05 CodingFabian