Odin icon indicating copy to clipboard operation
Odin copied to clipboard

OpenGL helpers.odin - Logging issue

Open RoboMage opened this issue 1 year ago • 0 comments

Context

In the OpenGL vendor library in the helpers.odin in check_error on lines 70 and 78 there's two commented out procedure calls for the print statements. With these commented out the entire function doesn't seem to serve any purpose. Also the commented out procs are undefined - "fmt.printf_err". If you replace it with fmt.eprintf everything works fine.

I am also confused on why there are two near identical functions called check_error here. Only differences is one doesn't print anything. If I'm way off the mark here, please let know

  • Operating System & Odin Version: Odin: dev-2024-08-nightly:8359995 OS: Windows 10 Professional (version: 22H2), build 19045.4651 CPU: AMD Ryzen 9 5950X 16-Core Processor RAM: 32688 MiB Backend: LLVM 18.1.8

Expected Behavior

load_shaders_source from the OpenGL helpers library should be logging errors

Current Behavior

No errors are currently getting logged

Steps to Reproduce

  • import gl "vendor:OpenGL"
  • Create an OpenGL context + window.
  • Create shader files or strings with a syntax error in it
  • Call gl.load_shaders_source(vertex_source, fragment_source)
  • Be sad when no errors are logged to the console

Failure Logs

n/a

RoboMage avatar Aug 10 '24 02:08 RoboMage