Odin icon indicating copy to clipboard operation
Odin copied to clipboard

Make MacOS releases self contained / bundle LLVM

Open laytan opened this issue 1 year ago • 3 comments

This makes all dynamic library dependencies bundle into dist/libs.

Just like before, macos will complain that the binary (and now additionally the bundled libraries) aren't signed/trusted, and you need to go to privacy settings to allow it to run. To be clear, this already happened before this change with the binary.

This PR also makes the action zip up the dist folder, this is to keep the executable permissions when downloading it back, see https://github.com/actions/upload-artifact/issues/38 for why.

laytan avatar Feb 22 '24 20:02 laytan

How much bigger will this be?

gingerBill avatar Feb 22 '24 20:02 gingerBill

It actually went down to 60MB because we are zipping it now. Here is a run I did on my fork: https://github.com/laytan/Odin/actions/runs/8010221628 if you want to check out the artifacts.

laytan avatar Feb 22 '24 20:02 laytan

Oh wow! This might be a great thing for everyone!

gingerBill avatar Feb 22 '24 20:02 gingerBill