Odin icon indicating copy to clipboard operation
Odin copied to clipboard

Improve build_odin.sh

Open sus-impost0r opened this issue 3 years ago • 1 comments

  • Fix a bug in config_darwin where a llvm-config version less than 13 would be accepted because a parameter expansion was forgotten.
  • Port the script to POSIX sh (replace [[ ]] with [ ], remove set -eu)
  • Quote Every Fucking Substitution consistently (except when necessary for proper fucntionality).
  • Style changes: Braces around variable names. Single quotes when no substitution is required.
  • Also removed unnecessary array use

sus-impost0r avatar Jun 20 '22 09:06 sus-impost0r

First is not a bug. We do support versions 11, 12, and 13.

gingerBill avatar Jun 20 '22 11:06 gingerBill